Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set warning to Eventing CR state if EventMesh secret is malformatted #490

Closed
muralov opened this issue Feb 15, 2024 · 1 comment · Fixed by #520
Closed

Set warning to Eventing CR state if EventMesh secret is malformatted #490

muralov opened this issue Feb 15, 2024 · 1 comment · Fixed by #520
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@muralov
Copy link
Contributor

muralov commented Feb 15, 2024

Description

If a user provides not proper EventMesh secret in case of EventMesh backend, the eventing CR has error state. However, it needs to have warning as it is a user caused error.

Expected result
Eventing CR status:

   ...
    - lastTransitionTime: "2024-02-09T13:37:36Z"
      message: 'invalid EventMesh secret for Event Publisher:
        messaging is missing from EM secret'
      reason: EventMeshSubscriptionManagerFailed
      status: "False"
      type: SubscriptionManagerReady
  state: Warning

Actual result
Eventing CR status:

   ...
    - lastTransitionTime: "2024-02-09T13:37:36Z"
      message: 'failed to sync Publisher Proxy secret: invalid secret for Event Publisher:
        messaging is missing from EM secret'
      reason: EventMeshSubscriptionManagerFailed
      status: "False"
      type: SubscriptionManagerReady
  state: Error

Steps to reproduce
make wrong event mesh secret format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
3 participants