Push result from FUs #792
Merged
Push result from FUs #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
added
refactor
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Hazardu
reviewed
Jan 25, 2025
|
It appears that a lot of code in FuncUnit derived classes is duplicated, are the exact same in almost all cases, with one exception being dummyLsu.py that renamed |
Indeed. This could probably be resolved by adding a base class for FUs, which would include a common constructor. This is not the subject of this PR, however - maybe you would be interested in doing such a refactor? |
|
Yes, i'll do it. Seems quite simple. |
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
piotro888
approved these changes
Jan 25, 2025
Hazardu
approved these changes
Jan 25, 2025
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my third attempt at changing the result direction in FUs from pull to push, and I think this is finally it. The change is very incremental - just enough to achieve the goal and nothing more. The change reduces the number of lines of code and even improves performance a little, thanks to removing some FIFOs. This is a good start for tuning the announcement part of the core.
Depends on #784.Merged.