Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not need reconcile when member cluster do not have mcs api #319

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: do not need reconcile when member cluster do not have mcs api #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/controllers/mcs/service_export_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,11 @@

svcName := eps.Labels[discoveryv1b1.LabelServiceName]
seListerInterface, synced, exists := c.fedInformerManager.GetResourceListerFromFactory(common.ServiceExportGVR, key.cluster)
if !exists || !synced() {
return true, fmt.Errorf("informer of serviceExport not exists or not synced for cluster %s", key.cluster)
if !exists {
return false, nil
}
if !synced() {
return true, fmt.Errorf("informer of serviceExport not synced for cluster %s", key.cluster)

Check warning on line 468 in pkg/controllers/mcs/service_export_controller.go

View check run for this annotation

Codecov / codecov/patch

pkg/controllers/mcs/service_export_controller.go#L464-L468 

Added lines #L464 - L468 were not covered by tests
}

seLister, ok := seListerInterface.(cache.GenericLister)
Expand Down
Loading