Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not need reconcile when member cluster do not have mcs api #319

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Poor12
Copy link
Collaborator

@Poor12 Poor12 commented Mar 27, 2024

No description provided.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 33.21%. Comparing base (73ab25f) to head (d57ab81).

Files Patch % Lines
pkg/controllers/mcs/service_export_controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   33.22%   33.21%   -0.01%     
==========================================
  Files         155      155              
  Lines       17885    17888       +3     
==========================================
  Hits         5942     5942              
- Misses      11434    11437       +3     
  Partials      509      509              
Flag Coverage Δ
unittests 33.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlihanbo mrlihanbo merged commit 733e4a6 into kubewharf:main Mar 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants