refactor(scheduler): adopt unified types #734
limhawjiaAnnotations
30 errors and 1 warning
|
typos
Process completed with exit code 2.
|
|
lint:
pkg/controllers/federatedcluster/clusterstatus.go#L181
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
|
|
lint:
pkg/controllers/policyrc/controller.go#L142
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
|
|
lint:
cmd/controller-manager/app/core.go#L33
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
|
|
lint:
pkg/controllers/status/controller.go#L302
cyclomatic complexity 36 of func `(*StatusController).reconcile` is high (> 30) (gocyclo)
|
|
lint:
pkg/controllers/federatedcluster/clusterstatus.go#L181
File is not `gofumpt`-ed (gofumpt)
|
|
lint:
pkg/controllers/policyrc/controller.go#L142
File is not `gofumpt`-ed (gofumpt)
|
|
lint:
cmd/controller-manager/app/core.go#L32
File is not `gofumpt`-ed (gofumpt)
|
|
lint:
pkg/util/informermanager/federatedinformermanager.go#L39
import "k8s.io/client-go/listers/core/v1" imported as "v1" but must be "corev1listers" according to config (importas)
|
|
lint
issues found
|
|
test (1.19):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.19):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.19):
pkg/controllers/follower/util_test.go#L306
undefined: FollowerReference
|
|
test (1.19):
pkg/controllers/follower/util_test.go#L309
undefined: FollowerReference
|
|
test (1.19):
pkg/controllers/follower/util_test.go#L317
undefined: getFollowersFromPod
|
|
test (1.19):
pkg/controllers/override/util_test.go#L301
cannot use obj (variable of type *unstructured.Unstructured) as type "github.com/kubewharf/kubeadmiral/pkg/apis/core/v1alpha1".GenericFederatedObject in argument to lookForMatchedPolicies:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L301
cannot use overridePolicyStore (variable of type "k8s.io/client-go/tools/cache".Store) as type "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".OverridePolicyLister in argument to lookForMatchedPolicies:
|
|
test (1.20):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.20):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.20):
pkg/controllers/follower/util_test.go#L306
undefined: FollowerReference
|
|
test (1.20):
pkg/controllers/follower/util_test.go#L309
undefined: FollowerReference
|
|
test (1.20):
pkg/controllers/follower/util_test.go#L317
undefined: getFollowersFromPod
|
|
test (1.20):
pkg/controllers/override/util_test.go#L301
cannot use obj (variable of type *unstructured.Unstructured) as "github.com/kubewharf/kubeadmiral/pkg/apis/core/v1alpha1".GenericFederatedObject value in argument to lookForMatchedPolicies: *unstructured.Unstructured does not implement "github.com/kubewharf/kubeadmiral/pkg/apis/core/v1alpha1".GenericFederatedObject (missing method DeepCopyGenericFederatedObject)
|
|
test (1.20):
pkg/controllers/override/util_test.go#L301
cannot use overridePolicyStore (variable of type "k8s.io/client-go/tools/cache".Store) as "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".OverridePolicyLister value in argument to lookForMatchedPolicies: "k8s.io/client-go/tools/cache".Store does not implement "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".OverridePolicyLister (wrong type for method List)
|
|
typos:
docs/quickstart.md#L6
"propgating" should be "propagating".
|