Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README file updated #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

README file updated #13

wants to merge 4 commits into from

Conversation

BushraNazish
Copy link

@BushraNazish BushraNazish commented Apr 2, 2022 •
edited
Loading

The contents for CONTRIBUTING.md is added in the README file

Closes #9

anubha-v-ardhan
anubha-v-ardhan reviewed Apr 2, 2022
View reviewed changes
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README needs to have a lot more things (see #1)
@dipankardas011 and @mayankkuamr001 showed interest in working on README, so you may want to collaborate with them

@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Apr 2, 2022
Open
@BushraNazish
Copy link
Author

Yeah, I would like to collaborate on this.
But according to #1 , README should have link to CONTRIBUTING.md. So, which way will it go then?

@anubha-v-ardhan
Copy link
Contributor

anubha-v-ardhan commented Apr 5, 2022 •
edited
Loading

@BushraNazish
@saiyam suggested here #11 (comment) to add things on README itself so we are going with no CONTRIBUTING.md I guess. I would recommend to confirm once with Saiyam as we usually using contributing file for this purpose

@saiyam1814
Copy link
Member

@BushraNazish with the new issue to PR template - it would be great to have the complete end to end flow in the readme with all the sites that a new person wants to do - once two PR's are merged can you put that in ?

@BushraNazish
Copy link
Author

Yes @saiyam1814 will do it. Vishal has worked on the PR template issue it seems. I will talk to him and get it merged.

@saiyam1814
Copy link
Member

@BushraNazish so we have a workflow running
Issue > PR > Tweet
Issue template is already there , I don't think we need a PR template and we can start the documentation process.

@BushraNazish
Copy link
Author

Sounds good @saiyam1814 👍

dipankardas011 and others added 3 commits April 24, 2022 14:58
@dipankardas011
Updated the Readme
34d0018 
Added workflow diagram
Added the Contribution List
Overall improvement
@dipankardas011
Merge branch 'update' into updatedReadme
4fb1f6c
@BushraNazish
Merge pull request #1 from dipankardas011/updatedReadme
51a59b0 
Updated the Readme 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create CONTRIBUTING.md for this project
4 participants
@BushraNazish @anubha-v-ardhan @saiyam1814 @dipankardas011