[cinder-csi-plugin] Add http endpoint of CSI container #1398

# kubectl get pods  -n kube-system -o wide
NAME                            READY   STATUS    RESTARTS   AGE   IP           NODE        NOMINATED NODE   READINESS GATES
csi-cinder-controllerplugin-0   6/6     Running   0          6s    172.17.0.3   127.0.0.1   <none>           <none>
csi-cinder-nodeplugin-2j5gg     3/3     Running   0          6s    127.0.0.1    127.0.0.1   <none>           <none>
kube-dns-58fd9b49f7-ffn4b       3/3     Running   0          59s   172.17.0.2   127.0.0.1   <none>           <none>
root@jjtest1:~/go/src/github.com/cloud-provider-openstack/manifests# kubectl run -i --tty curl1 --image=curlimages/curl --restart=Never
 -- sh
If you don't see a command prompt, try pressing enter.
/ $ curl 172.17.0.3:8080/metrics
# HELP process_start_time_seconds [ALPHA] Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.6124993369e+09

the result looks like this

jichenjc · 2021-02-05T04:34:01Z

/retest

theopenlab-ci · 2021-02-05T04:37:44Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 2m 44s

theopenlab-ci · 2021-02-05T04:38:24Z

Build succeeded.

cloud-provider-openstack-sanity-test-csi-cinder : SUCCESS in 3m 23s

jichenjc · 2021-04-21T06:19:53Z

/retest

theopenlab-ci · 2021-04-21T06:24:05Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 3m 03s

theopenlab-ci · 2021-04-21T06:24:18Z

Build succeeded.

cloud-provider-openstack-sanity-test-csi-cinder : SUCCESS in 3m 05s

theopenlab-ci · 2021-04-21T06:25:59Z

Build succeeded.

cloud-provider-openstack-unittest : SUCCESS in 4m 56s

theopenlab-ci · 2021-04-21T06:40:02Z

Build succeeded.

cloud-provider-openstack-acceptance-test-keystone-authentication-authorization : SUCCESS in 18m 12s

theopenlab-ci · 2021-04-21T06:45:56Z

Build succeeded.

cloud-provider-openstack-acceptance-test-lb-octavia : SUCCESS in 18m 43s

theopenlab-ci · 2021-04-21T06:52:10Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 25m 09s

theopenlab-ci · 2021-04-21T07:29:56Z

Build succeeded.

cloud-provider-openstack-e2e-test-csi-cinder : SUCCESS in 1h 08m 04s

theopenlab-ci · 2021-04-21T08:44:18Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20 : SUCCESS in 2h 17m 28s

theopenlab-ci · 2021-04-21T08:45:43Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance : SUCCESS in 2h 23m 41s

theopenlab-ci · 2021-04-21T08:49:58Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19 : SUCCESS in 2h 02m 55s

theopenlab-ci · 2021-04-21T09:36:07Z

Build succeeded.

cloud-provider-openstack-multinode-csi-migration-test : SUCCESS in 49m 23s

theopenlab-ci · 2021-04-21T10:02:59Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 : SUCCESS in 1h 17m 35s

jichenjc · 2021-04-22T05:34:02Z

/test cloud-provider-openstack-acceptance-test-csi-manila

k8s-ci-robot · 2021-04-22T05:34:03Z

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-04-22T06:50:40Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 1h 14m 26s

jichenjc · 2021-04-22T08:56:22Z

/test cloud-provider-openstack-acceptance-test-csi-manila

k8s-ci-robot · 2021-04-22T08:56:23Z

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-04-22T10:09:44Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 1h 11m 14s

k8s-ci-robot · 2021-04-28T14:55:08Z

@jichenjc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2021-07-27T15:25:10Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

ramineni · 2021-08-17T04:53:05Z

/close

please feel free to reopen , if you would like to work on it in future

k8s-ci-robot · 2021-08-17T04:53:19Z

@ramineni: Closed this PR.

In response to this:

/close

please feel free to reopen , if you would like to work on it in future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zetaab · 2022-05-31T06:34:51Z

@ramineni @jichenjc @chrigl it looks like discussion around cinder csi metrics started in year 2020. However, one reason why we do not have metrics yet is comment #1392 (comment) it is pretty difficult to implement. As I see it: we have already multiple components (occm+cinder-csi), why we should have common endpoint to retrieve metrics from all components? Why we cannot have own metrics endpoints for csi and occm?

So I am kind of asking: could we just use different way to provide metrics? Now we do not have anything.

For instance, AWS EBS CSI is using similar solution that was implemented in this PR. I think we should use this as starting point

kubernetes-sigs/aws-ebs-csi-driver#842

zetaab · 2022-05-31T07:14:22Z

dd83566

few things that we should think of:

it does not have any authentication, how easy it is use similar authentication method than occm has?
should cinder-csi component fetch other csi sidecar metrics internally and provide them?

jichenjc · 2022-05-31T09:41:30Z

should cinder-csi component fetch other csi sidecar metrics internally and provide them?

I am not sure this is best practice, at least I think metics comes from its own endpoint..

it does not have any authentication, how easy it is use similar authentication method than occm has?

should this be similar way? I don't see any reason we should be different on OCCM and CSI

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2021

k8s-ci-robot requested review from Fedosin and lingxiankong February 4, 2021 03:46

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2021

jichenjc force-pushed the add_http_endpoint_csi branch from 90476d0 to 38c3d65 Compare February 4, 2021 04:26

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2021

k8s-ci-robot closed this Aug 17, 2021

zetaab mentioned this pull request May 31, 2022

[cinder-csi-plugin] add support for openstack api metrics #1899

Closed

[cinder-csi-plugin] Add http endpoint of CSI container #1398

[cinder-csi-plugin] Add http endpoint of CSI container #1398

Conversation

jichenjc commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

theopenlab-ci bot commented Feb 4, 2021

jichenjc commented Feb 5, 2021

jichenjc commented Feb 5, 2021

theopenlab-ci bot commented Feb 5, 2021

theopenlab-ci bot commented Feb 5, 2021

jichenjc commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

theopenlab-ci bot commented Apr 21, 2021

jichenjc commented Apr 22, 2021

k8s-ci-robot commented Apr 22, 2021

theopenlab-ci bot commented Apr 22, 2021

jichenjc commented Apr 22, 2021

k8s-ci-robot commented Apr 22, 2021

theopenlab-ci bot commented Apr 22, 2021

k8s-ci-robot commented Apr 28, 2021

k8s-triage-robot commented Jul 27, 2021

ramineni commented Aug 17, 2021

k8s-ci-robot commented Aug 17, 2021

zetaab commented May 31, 2022 • edited Loading

zetaab commented May 31, 2022

jichenjc commented May 31, 2022

zetaab commented May 31, 2022 •

edited

Loading