Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] add support for openstack api metrics #1899

Closed
wants to merge 1 commit into from
Closed

[cinder-csi-plugin] add support for openstack api metrics #1899

wants to merge 1 commit into from
+62 −27

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented May 31, 2022 •
edited
Loading

What this PR does / why we need it:

see comment
#1398 (comment)
#1398 (comment)

Which issue this PR fixes(if applicable):
fixes #913

Special notes for reviewers:

Release note:

[cinder-csi-plugin] expose csi & openstack metrics by providing new flag `--http-endpoint`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from zetaab after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zetaab
Copy link
Member Author

zetaab commented May 31, 2022

/hold

still in progress

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@zetaab
Copy link
Member Author

zetaab commented May 31, 2022 •
edited
Loading

notes:

  • it does not have any authentication. If people does not want expose these metrics to whole cluster, they can use either rbac-proxy or networkpolicies to deny that.
  • should cinder-csi component fetch other csi sidecar metrics internally and provide them? I did not find any example of doing that. Asked in sig-storage slack channel and at least some people are fetching sidecar metrics from their own containers.

/hold cancel

@zetaab
Copy link
Member Author

zetaab commented May 31, 2022

/hold cancel

@chrigl @jichenjc could you check this? I do not understand why cinder-e2e-test is crashlooping, I cannot reproduce that locally using new image created from this PR.

As I see it, we need these metrics. I know - its not the best way to expose these if we compare to OCCM. However, its better than nothing.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@jichenjc
Copy link
Contributor

#1898
also failed , so it's gate issue but don't know reason so far ..

@chrigl
Copy link
Contributor

chrigl commented May 31, 2022

first... also ignoring the fact that e2e doesn't work at the moment. Before the crash loop it was incredibly flaky.

In general absolute +1 for having metrics. But is this something we want to have in that form in for 1.24, or do we want to bring it in v1.25. If 1.25 is our target, would it make sense to think through it and come up with an idea to do it "better" (what ever better in that context means)? The answer cold also be both :)

@zetaab
Copy link
Member Author

zetaab commented May 31, 2022

@chrigl as I see it 1.25 could be the target. Its fine for me to put this on hold and think better options. With this we can get it working and its done in similar way for instance in AWS side. sig-storage did not bring any new ideas to this "issue".

@chrigl chrigl added this to the v1.25 milestone Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2022
@k8s-ci-robot
Copy link
Contributor

@zetaab: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@zetaab: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-keystone-authentication-authorization-test dd83566 link true /test openstack-cloud-keystone-authentication-authorization-test
openstack-cloud-controller-manager-e2e-test dd83566 link true /test openstack-cloud-controller-manager-e2e-test
openstack-cloud-csi-cinder-e2e-test dd83566 link true /test openstack-cloud-csi-cinder-e2e-test
openstack-cloud-csi-manila-e2e-test dd83566 link true /test openstack-cloud-csi-manila-e2e-test
openstack-cloud-csi-cinder-sanity-test dd83566 link true /test openstack-cloud-csi-cinder-sanity-test
openstack-cloud-csi-manila-sanity-test dd83566 link true /test openstack-cloud-csi-manila-sanity-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MPV
Copy link
Contributor

MPV commented Aug 16, 2023

I agree metrics would be really helpful (currently having issues communicating with Cinder API, being able to easily measure and quantify it would be really useful).

Any thoughts on what next steps could be here?

@zetaab
Copy link
Member Author

zetaab commented Aug 16, 2023 •
edited
Loading

@MPV metrics are merged in #2077 and available in 1.27 release (by default disabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] metrics are not accessible
6 participants
@zetaab @k8s-ci-robot @jichenjc @chrigl @k8s-triage-robot @MPV