Skip to content

fix(generic comment): avoid ok-to-test message on IgnoreOkToTest #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/plugins/trigger/generic-comment.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,12 @@ func handleGenericComment(c Client, trigger plugins.Trigger, gc github.GenericCo
return err
}
if !trusted {
resp := "Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message."
var resp string
if trigger.IgnoreOkToTest {
resp = "PRs from untrusted users cannot be marked as trusted with `/ok-to-test` in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using `/test`."
} else {
resp = "Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message."
}
c.Logger.Infof("Commenting \"%s\".", resp)
return c.GitHubClient.CreateComment(org, repo, number, plugins.FormatResponseRaw(gc.Body, gc.HTMLURL, gc.User.Login, resp))
}
Expand Down