Skip to content

fix(generic comment): avoid ok-to-test message on IgnoreOkToTest #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix(generic comment): avoid ok-to-test message on IgnoreOkToTest #465

merged 1 commit into from
May 22, 2025
+6 −1

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented May 19, 2025 •
edited
Loading

Emit a message similar to the welcome message in case of untrusted user and trigger.IgnoreOkToTest.

See kubevirt/kubevirt#14110 (comment)

@netlify Netlify
Copy link

netlify bot commented May 19, 2025 •
edited
Loading

✅ Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit e7cc426
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/682da3da21c4dc0008915704
😎 Deploy Preview https://deploy-preview-465--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @dhiller!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dhiller. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the area/plugins Issues or PRs related to prow's plugins for the hook component label May 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2025
@dhiller dhiller mentioned this pull request May 19, 2025
Open
8 tasks
0xFelix
0xFelix reviewed May 20, 2025
View reviewed changes
pkg/plugins/trigger/generic-comment.go Outdated
resp := "Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message."
var resp string
if trigger.IgnoreOkToTest {
resp = "PRs from untrusted users cannot be marked as trusted with `/ok-to-test` in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using `/test all`."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention that individual tests can be triggered too, not just all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xFelix I think I agree that we should not suggest to always run /test all, maybe just /test is enough. WDYT?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that sounds good

@dhiller
fix(generic comment): avoid ok-to-test message on IgnoreOkToTest
e7cc426 
Emit a message similar to the welcome message in case of untrusted user
and trigger.IgnoreOkToTest.

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller dhiller force-pushed the handle-untrusted-user-and-ignore-ok-to-test branch from 8b46ef7 to e7cc426 Compare May 21, 2025 09:58
0xFelix
0xFelix approved these changes May 21, 2025
View reviewed changes
Copy link

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@0xFelix: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Prucek
Copy link
Member

Prucek commented May 22, 2025

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@smg247
Copy link
Contributor

smg247 commented May 22, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, dhiller, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8173b70 into kubernetes-sigs:main May 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@petr-muller petr-muller Awaiting requested review from petr-muller

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@Prucek Prucek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugins Issues or PRs related to prow's plugins for the hook component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhiller @k8s-ci-robot @Prucek @smg247 @0xFelix