Skip Get-WindowsFeature goss spec for windows-2025 #1619
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @jsturtevant @TinaMor |
|
@mboersma: GitHub didn't allow me to request PR reviews from the following users: TinaMor. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mboersma
added
the
sig/windows
|
/test pull-azure-sigs |
| # PowerShell command to Get Windows Features. | ||
| {{ if eq .Vars.OS "windows"}} # Windows | ||
| # Workaround until windows features are added to goss | ||
| command: | ||
| {{range $name, $vers := index .Vars .Vars.OS "common-windows-features"}} | ||
| "Windows Feature - {{ $name }}": | ||
| exec: powershell -command "(Get-WindowsFeature {{ $name }} | select *)" | ||
| exec: powershell -command "(for ($i = 0; $i -lt 2; $i++) {Get-WindowsFeature {{ $name }} | select *})" |
There was a problem hiding this comment.
@mboersma Not sure if this will work in the 30sec. Instead, we are using goss to retry. If it fails in 30sec, we retry until the max time out in goss-args.json
cc. @jsturtevant
There was a problem hiding this comment.
Ah, so you're retrying the whole goss suite until timeout? That should be more robust. Sorry, I didn't know you were addressing this in #1576. I'm curious to see how this fails, but I'll close it afterward.
There was a problem hiding this comment.
I had also previously tried adding some ansible debug statements right after we enable the features, using community.windows.win_feature_info. It showed both features were installed correctly, but it also seemed to have the side effect of making the existing goss test pass. 🤷🏻
There was a problem hiding this comment.
Here is a sample run:
artifacts/azure-sigs/windows-2025-containerd.log
There was a problem hiding this comment.
adding some ansible debug statements right after we enable the features,
Interesting. This may work. The issue is with Get-WindowsFeature cmdlet. It fails on the first try on a fresh install, but passes the when executed again. Perhaps community.windows.win_feature_info already calls the cmdlet so when the test is run by Goss, it doesn't fail. Will investigate.
Should we skip the test for 2025 for now?
There was a problem hiding this comment.
We are skipping the windows-2025 SIG test in CI currently as of #1604.
As for the debug statement side effect, I only ran it twice so I'm not that confident, but it did fail 100% of the time before that.
There was a problem hiding this comment.
We could add back the WS2025 CI. The issues with 2025 are gMSA (addressed by #1576) and timeout when querying Windows features (investigating).
If we skip the Windows feature test, the tests should run successfully.
There was a problem hiding this comment.
I redid this PR just to skip the Get-WindowsFeature test on windows-2025 for now, and to turn the windows-2025 sig build back on in CI.
mboersma
force-pushed
the
fix-windows-2025
branch
from
39c0497 to
87a3ca9
Compare
|
/retitle Skip Get-WindowsFeature goss spec for windows-2025 |
k8s-ci-robot
changed the title
|
/test pull-azure-sigs Edit: |
|
Unfortunate that the powershell command doesn't work properly on Windows 2025. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Change description
Tries the
Get-WindowsFeaturegoss test spec twice to work around an issue with windows-2025. Also restores the Azure windows-2025 build to CI runs.Related issues
Additional context