-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gMSA setup on Windows #1576
Conversation
Hi @TinaMor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@TinaMor: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/test pull-azure-sigs |
/test pull-azure-sigs |
1 similar comment
/test pull-azure-sigs |
cb4ec4f
to
8185aef
Compare
@TinaMor could you rebase this? |
/test pull-azure-sigs |
1 similar comment
/test pull-azure-sigs |
/test pull-azure-sigs |
/test pull-azure-sigs |
gmsa installer check worked. powershell timedout and should be resolved with #1619 |
/test pull-azure-sigs |
/test pull-azure-sigs Edit: sig-windows-2025-containerd: SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @jsturtevant
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR Description
This PR resilves the following issues caused when trying to import registry keys from registerplugin.reg:
TL;DR
The gMSA setup on WS2025 fails with the error:
Error opening the file. There may be a disk or file system error.
image-builder/images/capi/ansible/windows/roles/gmsa/files/install-gmsa-keyvault-plugin.ps1
Line 119 in e224d7c
To resolve the issue, we now use an absolute path to the registerplugin.reg file since it is copied to the same location where the install-gmsa-keyvault-plugin.ps1 script is executed.
image-builder/images/capi/ansible/windows/roles/gmsa/tasks/gmsa_keyvault.yml
Line 43 in e224d7c
reg.exe import
fails with "Failed to open registry key"This happens when the registry keys already exist. To resolve this, we parse the registerplugin.reg file (downloaded from kubernetesartifacts.azureedge.net/ccgakvplugin) to identify all the registry keys that will be updated by importing registerplugin.reg, we transfer ownership to the user and then restore it to the original owner.