Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set Python 3.9 as the Minimum Supported Version #11159

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/backend-visualization.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.9'

- name: Run tests
run: ./test/presubmit-backend-visualization.sh
1 change: 0 additions & 1 deletion .github/workflows/kfp-kubernetes-library-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
strategy:
matrix:
python: [
{ 'version': '3.8' },
{ 'version': '3.9' },
{ 'version': '3.10' },
{ 'version': '3.11' },
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kfp-sdk-runtime-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-24.04
strategy:
matrix:
python: ['3.8', '3.9', '3.10', '3.11', '3.12']
python: ['3.9', '3.10', '3.11', '3.12']
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kfp-sdk-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8, 3.9, 3.10, 3.11, 3.12]
python-version: [3.9, 3.10, 3.11, 3.12]

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kubeflow-pipelines-integration-v2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8]
python-version: [3.9]

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sdk-component-yaml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- name: apt-get update
run: sudo apt-get update
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sdk-docformatter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- name: Run docformatter tests
run: ./test/presubmit-docformatter-sdk.sh
2 changes: 1 addition & 1 deletion .github/workflows/sdk-isort.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- name: Run isort tests
run: ./test/presubmit-isort-sdk.sh
2 changes: 1 addition & 1 deletion .github/workflows/sdk-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- name: Run SDK upgrade tests
run: ./test/presubmit-test-sdk-upgrade.sh
2 changes: 1 addition & 1 deletion .github/workflows/sdk-yapf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.9'

- name: Install dependencies
run: pip install yapf
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ python:
build:
os: ubuntu-22.04
tools:
python: "3.8"
python: "3.9"
4 changes: 2 additions & 2 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ fill in the description. Detailed steps:
<pre>
To deploy Kubeflow Pipelines in an existing cluster, follow the instruction in [here](https://www.kubeflow.org/docs/pipelines/standalone-deployment-gcp/) or via UI [here](https://console.cloud.google.com/ai-platform/pipelines)

Install python SDK (python 3.7 above) by running:
Install python SDK (python 3.9 above) by running:

```bash
python3 -m pip install kfp kfp-server-api --upgrade
Expand All @@ -306,7 +306,7 @@ fill in the description. Detailed steps:
<pre>
To deploy Kubeflow Pipelines in an existing cluster, follow the instruction in [here](https://www.kubeflow.org/docs/pipelines/standalone-deployment-gcp/).

Install kfp-server-api package (python 3.7 above) by running:
Install kfp-server-api package (python 3.9 above) by running:

```bash
python3 -m pip install kfp-server-api==$VERSION --upgrade
Expand Down
2 changes: 1 addition & 1 deletion api/v2alpha1/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
author_email='[email protected]',
url='https://github.com/kubeflow/pipelines',
packages=setuptools.find_namespace_packages(include=['kfp.*']),
python_requires='>=3.7.0,<3.13.0',
python_requires='>=3.9.0,<3.13.0',
install_requires=['protobuf>=4.21.1,<5'],
include_package_data=True,
license='Apache 2.0',
Expand Down
2 changes: 1 addition & 1 deletion backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ RUN go-licenses csv ./backend/src/apiserver > /tmp/licenses.csv && \
go-licenses save ./backend/src/apiserver --save_path /tmp/NOTICES

# 2. Compile preloaded pipeline samples
FROM python:3.8 as compiler
FROM python:3.9 as compiler
RUN apt-get update -y && apt-get install --no-install-recommends -y -q default-jdk python3-setuptools python3-dev jq
RUN wget https://bootstrap.pypa.io/get-pip.py && python3 get-pip.py
COPY backend/requirements.txt .
Expand Down
2 changes: 1 addition & 1 deletion backend/Dockerfile.conformance
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ RUN chmod +x /test/integration/run.sh
RUN tar -czvf /test.tar.gz /test


FROM alpine:3.8
FROM alpine:3.9

COPY --from=builder /test.tar.gz /
RUN tar -xzvf /test.tar.gz
Expand Down
33 changes: 0 additions & 33 deletions backend/api/v1beta1/python_http_client/.gitlab-ci.yml

This file was deleted.

17 changes: 0 additions & 17 deletions backend/api/v1beta1/python_http_client/.travis.yml

This file was deleted.

33 changes: 0 additions & 33 deletions backend/api/v2beta1/python_http_client/.gitlab-ci.yml

This file was deleted.

17 changes: 0 additions & 17 deletions backend/api/v2beta1/python_http_client/.travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion backend/metadata_writer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ml-metadata package depends on tensorflow package
FROM python:3.8
FROM python:3.9
COPY backend/metadata_writer/requirements.txt /kfp/metadata_writer/
RUN python3 -m pip install -r /kfp/metadata_writer/requirements.txt

Expand Down
2 changes: 1 addition & 1 deletion backend/metadata_writer/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.9
# by the following command:
#
# pip-compile --output-file=- -
Expand Down
2 changes: 1 addition & 1 deletion backend/metadata_writer/update_requirements.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash

# This image should be in sync with Dockerfile.
IMAGE="python:3.8"
IMAGE="python:3.9"
../../hack/update-requirements.sh $IMAGE <requirements.in >requirements.txt
8 changes: 4 additions & 4 deletions backend/src/apiserver/resource/resource_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3512,15 +3512,15 @@ spec:
- name: ENABLE_CACHING
valueFrom:
fieldRef: {fieldPath: 'metadata.labels[''pipelines.kubeflow.org/enable_caching'']'}
- {name: KFP_V2_IMAGE, value: 'python:3.7'}
- {name: KFP_V2_IMAGE, value: 'python:3.9'}
- {name: KFP_V2_RUNTIME_INFO, value: '{"inputParameters": {"num_steps": {"type":
"INT"}}, "inputArtifacts": {"dataset": {"metadataPath": "/tmp/inputs/dataset/data",
"schemaTitle": "system.Dataset", "instanceSchema": ""}}, "outputParameters":
{}, "outputArtifacts": {"model": {"schemaTitle": "system.Model", "instanceSchema":
"", "metadataPath": "/tmp/outputs/model/data"}}}'}
envFrom:
- configMapRef: {name: metadata-grpc-configmap, optional: true}
image: python:3.7
image: python:3.9
volumeMounts:
- {mountPath: /kfp-launcher, name: kfp-launcher}
inputs:
Expand Down Expand Up @@ -4044,7 +4044,7 @@ deploymentSpec:
_parsed_args = vars(_parser.parse_args())

_outputs = hello_world(**_parsed_args)
image: python:3.7
image: python:3.9
pipelineInfo:
name: hello-world
root:
Expand Down Expand Up @@ -4077,7 +4077,7 @@ deploymentSpec:
executors:
exec-hello-world:
container:
image: python:3.7
image: python:3.9
pipelineInfo:
name: pipelines/p1/versions/v1
root:
Expand Down
4 changes: 2 additions & 2 deletions backend/src/apiserver/resource/resource_manager_util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ spec:
command:
- python
- -c
image: python:alpine3.6
image: python:alpine3.9
name: ""
resources: {}
inputs: {}
Expand Down Expand Up @@ -181,7 +181,7 @@ spec:
command:
- python
- -c
image: python:alpine3.6
image: python:alpine3.9
name: ""
resources: {}
inputs: {}
Expand Down
12 changes: 6 additions & 6 deletions backend/src/apiserver/server/pipeline_upload_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ deploymentSpec:
_parsed_args = vars(_parser.parse_args())

_outputs = hello_world(**_parsed_args)
image: python:3.7
image: python:3.9
pipelineInfo:
name: hello-world
root:
Expand Down Expand Up @@ -724,7 +724,7 @@ deploymentSpec:
_parsed_args = vars(_parser.parse_args())

_outputs = hello_world(**_parsed_args)
image: python:3.7
image: python:3.9
pipelineInfo:
name: hello-world
root:
Expand Down Expand Up @@ -765,7 +765,7 @@ deploymentSpec:
executors:
exec-hello-world:
container:
image: python:3.7
image: python:3.9
pipelineInfo:
name: hello-world-
root:
Expand All @@ -790,7 +790,7 @@ deploymentSpec:
executors:
exec-hello-world:
container:
image: python:3.7
image: python:3.9
pipelineInfo:
name: hEllo-world
root:
Expand All @@ -815,7 +815,7 @@ deploymentSpec:
executors:
exec-hello-world:
container:
image: python:3.7
image: python:3.9
pipelineInfo:
name: more than 128 characters more than 128 characters more than 128 characters more than 128 characters more than 128 characters
root:
Expand All @@ -840,7 +840,7 @@ deploymentSpec:
executors:
exec-hello-world:
container:
image: python:3.7
image: python:3.9
pipelineInfo:
name: hello-worl.d
root:
Expand Down
6 changes: 3 additions & 3 deletions backend/src/apiserver/server/test/pipeline_with_volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ deploymentSpec:
'
- "\nimport kfp\nfrom kfp import dsl\nfrom kfp.dsl import *\nfrom typing import\
\ *\n\ndef comp():\n pass\n\n"
image: python:3.7
image: python:3.9
exec-comp-2:
container:
args:
Expand All @@ -92,7 +92,7 @@ deploymentSpec:
'
- "\nimport kfp\nfrom kfp import dsl\nfrom kfp.dsl import *\nfrom typing import\
\ *\n\ndef comp():\n pass\n\n"
image: python:3.7
image: python:3.9
exec-comp-3:
container:
args:
Expand All @@ -118,7 +118,7 @@ deploymentSpec:
'
- "\nimport kfp\nfrom kfp import dsl\nfrom kfp.dsl import *\nfrom typing import\
\ *\n\ndef comp():\n pass\n\n"
image: python:3.7
image: python:3.9
exec-createpvc:
container:
image: argostub/createpvc
Expand Down
Loading
Loading