chore: Set Python 3.9 as the Minimum Supported Version #11159
Conversation
|
Skipping CI for Draft Pull Request. |
google-oss-prow
bot
requested review from
Ark-kun,
connor-mccarthy,
DharmitD,
gkcalat,
gregsheremeta,
HumairAK,
jlyaoyuli,
rimolive and
zijianjoy
|
Follow up of #10950 |
diegolovison
force-pushed
the
py39
branch
2 times, most recently
from
0a5714b
to
1c62a84
Compare
diegolovison
changed the title
| @@ -1,33 +0,0 @@ | |||
| # ref: https://docs.gitlab.com/ee/ci/README.html | |||
There was a problem hiding this comment.
do we know what these ci files were for? why are we removing them as part of the python 3.9 upgrade?
There was a problem hiding this comment.
They were removed because they are not part of our infrastructure and they contain Python images that are not the minimum required ( Python 3.9 ). If they are using, let's say by Google, they should update and I will undo the removal on my PR. I created an entry for the next meeting to make sure they are aware of that and also updated the description of the PR.
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.8 | |||
| # This file is autogenerated by pip-compile with Python 3.9 | |||
There was a problem hiding this comment.
For future reference can you drop a comment in the pr post on how you re-generated this file, it will be useful in the future for the next person that performs a similar pr for a newer version
There was a problem hiding this comment.
Each requirements.txt generated from pip-compile includes a comment with the command that was used to generate it. By checking the content of the file above, you'll find the following:
#
# This file is autogenerated by pip-compile with Python 3.9
# by the following command:
#
# pip-compile --output-file=- --resolver=backtracking -
#
| @@ -8,17 +8,17 @@ spec: | |||
| parameters: | |||
| - name: kubernetes-comp-comp | |||
| value: '{"pvcMount":[{"mountPath":"/data","taskOutputParameter":{"outputParameterKey":"name","producerTask":"createpvc"}}]}' | |||
| - name: components-95f802401136aebf1bf728a6675d7adba5513b53673a3698e00a6d8744638080 | |||
| - name: components-b34273359995b3746ecf1bb58ac4bd6c54d47b6fdc35b013bb7962946f322a19 | |||
There was a problem hiding this comment.
similar to this maybe adding your steps on how you generated these would be useful in the future.
There was a problem hiding this comment.
The test will fail and the output will be that you should update to b34273359995b3746ecf1bb58ac4bd6c54d47b6fdc35b013bb7962946f322a19
|
@diegolovison: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm this will need to be rebased however |
Signed-off-by: Diego Lovison <[email protected]>
|
/lgtm |
|
cc @chensun It would be nice to get this merged as maintaining this PR long term is a bit of a pain due to the number of files affected. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Amazing, this is what would like to have in Kubeflow 1.10. |
Signed-off-by: Diego Lovison <[email protected]> Signed-off-by: sefgsefg <[email protected]>
Signed-off-by: Diego Lovison <[email protected]> Signed-off-by: sefgsefg <[email protected]>
Signed-off-by: Diego Lovison <[email protected]>
Signed-off-by: Diego Lovison <[email protected]>
Description of your changes:
As of October 2024, Python 3.8 has officially reached the end of its maintenance period. This means that it will no longer receive security updates, bug fixes, or any further support from the Python development team. To ensure the ongoing security and stability of our project, it is strongly recommended to upgrade to a more recent and supported version of Python. Continuing to use Python 3.8 may expose the project to security vulnerabilities and compatibility issues.
xgboost_sample_pipeline.pybecause it contains files fromcomponents/XGBoostthat were removed..gitlab-ci.ymland.travis.ymlwere removed because they are not part of our infrastructure and they contain Python images that are not the minimum required ( Python 3.9 ).Checklist: