Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add vModelId to PayloadProcessor Payload #123

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: Add vModelId to PayloadProcessor Payload #123

merged 2 commits into from
Nov 28, 2023

Commits on Nov 24, 2023

  1. feat: Add vModelId to PayloadProcessor Payload 

    Motivation

Currently the payloads passed to PayloadProcessors only contain the modelId, which in the case of vModels will be a "resolved" modelId corresponding to a particular model revision (in particular this will be true when used in KServe modelmesh-serving). It would be useful to include the vModelId too.

Modifications

Add a vModelId field to the Payload class and correspondingly update built-in PayloadProcessor implementations where applicable.

It may be null if the request was directed at a concrete modelId rather than a vModelId.

Result

Both modelId and vModelId are available to PayloadProcessors

Signed-off-by: Nick Hill <[email protected]>
    @njhill @ckadner
    njhill authored and ckadner committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b3dfb38 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Merge branch 'main' into vmodelid-in-payload 

    Signed-off-by: Christian Kadner <[email protected]>
    @ckadner
    ckadner authored Nov 25, 2023
    Configuration menu
    Copy the full SHA
    5dc412f View commit details
    Browse the repository at this point in the history