feat: Add vModelId to PayloadProcessor Payload #123
Conversation
|
FYI @RobGeada |
|
@ckadner yes, ideally we should add such unit tests. |
Do I remember you mentioned adding a unit test could be done using some existing helper functions without the overhead of setting up an extensive end-to-end test environment. If it could be done with reasonable effort, should we create an issue to track it where you could add some pointers? Was it this? #112 (comment) |
Motivation Currently the payloads passed to PayloadProcessors only contain the modelId, which in the case of vModels will be a "resolved" modelId corresponding to a particular model revision (in particular this will be true when used in KServe modelmesh-serving). It would be useful to include the vModelId too. Modifications Add a vModelId field to the Payload class and correspondingly update built-in PayloadProcessor implementations where applicable. It may be null if the request was directed at a concrete modelId rather than a vModelId. Result Both modelId and vModelId are available to PayloadProcessors Signed-off-by: Nick Hill <[email protected]>
ckadner
force-pushed
the
vmodelid-in-payload
branch
from
2e4d1d6
to
b3dfb38
Compare
Signed-off-by: Christian Kadner <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
I see @njhill gave his |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill, tteofili The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
Currently the payloads passed to PayloadProcessors only contain the modelId, which in the case of vModels will be a "resolved" modelId corresponding to a particular model revision (in particular this will be true when used in KServe modelmesh-serving). It would be useful to include the vModelId too.
Modifications
Add a
vModelIdfield to thePayloadclass and correspondingly update built-inPayloadProcessorimplementations where applicable.It may be null if the request was directed at a concrete modelId rather than a vModelId.
Result
Both modelId and vModelId are available to PayloadProcessors