Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Core Schema by default as recommended by the YAML specification #390

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Feb 2, 2025

No description provided.

@Vampire
Copy link
Contributor Author

Vampire commented Feb 2, 2025

Follow-up of #408

The YAML specification in "10.3. Core Schema" says

This is the recommended default schema that YAML processor should use unless instructed otherwise.

But SYE uses the JSON schema by default, probably because in the beginning it did not support schemas at all and there was not able to handle the Core schema types. (https://bitbucket.org/snakeyaml/snakeyaml-engine/issues/38/core-schema-cannot-parse-integers-encoded)

This PR changes here the default to be the Core Schema, as recommended by the YAML specification.

@Vampire Vampire force-pushed the core-schema-default branch from 7680490 to e55cdb7 Compare February 12, 2025 03:45
@Vampire Vampire marked this pull request as draft February 12, 2025 03:46
@Vampire Vampire requested a review from krzema12 February 12, 2025 03:46
@Vampire Vampire force-pushed the core-schema-default branch 4 times, most recently from 345ae30 to ebe5f9f Compare February 12, 2025 10:29
@Vampire Vampire force-pushed the core-schema-default branch from ebe5f9f to 482a6ac Compare February 12, 2025 16:57
@Vampire Vampire marked this pull request as ready for review February 12, 2025 16:57
@krzema12 krzema12 enabled auto-merge (squash) February 13, 2025 10:49
@krzema12 krzema12 merged commit ac01468 into krzema12:main Feb 13, 2025
12 checks passed
@Vampire Vampire deleted the core-schema-default branch February 13, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants