Use Core Schema by default as recommended by the YAML specification

krzema12 · Feb 12, 2025 · 482a6ac · 482a6ac
1 parent a829841
commit 482a6ac
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/commonMain/kotlin/it/krzeminski/snakeyaml/engine/kmp/schema/Schema.kt b/src/commonMain/kotlin/it/krzeminski/snakeyaml/engine/kmp/schema/Schema.kt
@@ -17,7 +17,7 @@ import it.krzeminski.snakeyaml.engine.kmp.api.ConstructNode
 import it.krzeminski.snakeyaml.engine.kmp.nodes.Tag
 import it.krzeminski.snakeyaml.engine.kmp.resolver.ScalarResolver
 
-internal val DEFAULT_SCHEMA = JsonSchema()
+internal val DEFAULT_SCHEMA = CoreSchema()
 
 /**
  * Interface to be implemented by any Schema

diff --git a/src/jvmTest/java/org/snakeyaml/engine/v2/api/LoadSettingsTest.java b/src/jvmTest/java/org/snakeyaml/engine/v2/api/LoadSettingsTest.java
@@ -26,7 +26,7 @@
 import org.junit.jupiter.api.Test;
 import it.krzeminski.snakeyaml.engine.kmp.api.LoadSettings.SpecVersionMutator;
 import it.krzeminski.snakeyaml.engine.kmp.exceptions.DuplicateKeyException;
-import it.krzeminski.snakeyaml.engine.kmp.schema.JsonSchema;
+import it.krzeminski.snakeyaml.engine.kmp.schema.CoreSchema;
 
 @Tag("fast")
 class LoadSettingsTest {
@@ -104,10 +104,10 @@ void bufferSize() {
   }
 
   @Test
-  @DisplayName("Use JSON schema by default")
+  @DisplayName("Use Core schema by default")
   void defaultSchema() {
     LoadSettings settings = LoadSettings.builder().build();
-    assertEquals(JsonSchema.class, settings.schema.getClass());
+    assertEquals(CoreSchema.class, settings.schema.getClass());
   }
 
   public enum SomeStatus implements SettingKey {

diff --git a/src/jvmTest/java/org/snakeyaml/engine/v2/api/dump/DumpSettingsTest.java b/src/jvmTest/java/org/snakeyaml/engine/v2/api/dump/DumpSettingsTest.java
@@ -24,6 +24,7 @@
 import it.krzeminski.snakeyaml.engine.kmp.common.ScalarStyle;
 import it.krzeminski.snakeyaml.engine.kmp.common.SpecVersion;
 import it.krzeminski.snakeyaml.engine.kmp.exceptions.EmitterException;
+import it.krzeminski.snakeyaml.engine.kmp.schema.CoreSchema;
 
 import java.util.*;
 
@@ -151,6 +152,13 @@ void dumpCustomProperty() {
     assertNull(settings.getCustomProperty(new KeyName("None")));
   }
 
+  @Test
+  @DisplayName("Use Core schema by default")
+  void defaultSchema() {
+    DumpSettings settings = DumpSettings.builder().build();
+    assertEquals(CoreSchema.class, settings.schema.getClass());
+  }
+
   static class KeyName implements SettingKey {
 
     private final String keyName;