FIX Twig2.0 compatibility #854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not extending final function allow this function to work with Twig 2.0
Tobion
suggested changes
Nov 29, 2017
There was a problem hiding this comment.
This is not the proper fix. In Twig 1.x the Twig_Function is deprecated. So this would require the update the conflict composer rule to forbid 1.x. But also in 2.x extending Twig_Function is deprecated as well.
So the only solution is to not use a custom class for the twig function, but use Twig_Function directly where needed.
|
This has been implemented in the 2.0 branch of assetic-php/assetic. Until we tag 2.0, you can pull it in by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not extending final function allow this function to work with Twig 2.0