Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Fatal error AsseticFilterFunction may not inherit from final class (Twig_SimpleFunction) #835

Open
gondo opened this issue Jan 6, 2017 · 6 comments

Comments

@gondo
Copy link

gondo commented Jan 6, 2017

after running composer update on my project and after
running app/console --env=test cache:clear it failed with this error:

PHP Fatal error:  Class Assetic\Extension\Twig\AsseticFilterFunction may not inherit from final class (Twig_SimpleFunction) in ~/project/vendor/kriswallsmith/assetic/src/Assetic/Extension/Twig/AsseticFilterFunction.php on line 24
@gondo
Copy link
Author

gondo commented Jan 6, 2017

only works for "twig/twig": "<2.0"

@stof
Copy link
Collaborator

stof commented Jan 6, 2017

arf, I forgot that we add a class extending it here, and that Twig made them final.

the work is almost done to get rid of it. I will work on it this evening. In the meantime, stick to Twig 1.x

@eDavidT
Copy link

eDavidT commented Feb 21, 2017

Any update on when this will get fixed?

@smcjones
Copy link

Symfony 3.3 now triggers an error for this.

The "Twig_TokenParser_Include" class is considered final. It may change without further notice as of its next major version. You should not extend it from "Twig_TokenParser_Embed"

@OnekO
Copy link

OnekO commented Jun 2, 2017

This can be easily fix with this patch: #854

@hvt
Copy link

hvt commented Aug 2, 2017

Hey @stof, do you have an update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants