ci: optimize make generate and update to go 1.19

docker/koord-descheduler.dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.18 as builder
+FROM golang:1.19 as builder
 WORKDIR /go/src/github.com/koordinator-sh/koordinator
 
 COPY go.mod go.mod

docker/koord-manager.dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.18 as builder
+FROM golang:1.19 as builder
 WORKDIR /go/src/github.com/koordinator-sh/koordinator
 
 COPY go.mod go.mod

docker/koord-runtimeproxy.dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.18 as builder
+FROM golang:1.19 as builder
 WORKDIR /go/src/github.com/koordinator-sh/koordinator
 
 COPY go.mod go.mod

docker/koord-scheduler.dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.18 as builder
+FROM golang:1.19 as builder
 WORKDIR /go/src/github.com/koordinator-sh/koordinator
 
 COPY go.mod go.mod

docker/koordlet.dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.18 as builder
+FROM golang:1.19 as builder
 WORKDIR /go/src/github.com/koordinator-sh/koordinator
 
 COPY go.mod go.mod

go.mod

@@ -1,6 +1,6 @@
 module github.com/koordinator-sh/koordinator
 
-go 1.18
+go 1.19
 
 require (
 	github.com/NVIDIA/go-nvml v0.11.6-0.0.20220823120812-7e2082095e82

hack/update-codegen.sh

@@ -28,6 +28,13 @@ export GOPATH
 SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 ROOT_PKG=github.com/koordinator-sh/koordinator
 
+if [ ! -d "${SCRIPT_ROOT}/vendor" ]; then
+  go mod vendor
+fi
+
+GO111MODULE="off"
+export GO111MODULE
+
 # code-generator does work with go.mod but makes assumptions about
 # the project living in `$GOPATH/src`. To work around this and support
 # any location; create a temporary directory, use this as an output
@@ -45,29 +52,40 @@ echo ">> Temporary output directory ${TEMP_DIR}"
 # --output-base    because this script should also be able to run inside the vendor dir of
 #                  k8s.io/kubernetes. The output-base is needed for the generators to output into the vendor dir
 #                  instead of the $GOPATH directly. For normal projects this can be dropped.
-$SCRIPT_ROOT/hack/generate-groups.sh "client,informer,lister" \
- github.com/koordinator-sh/koordinator/pkg/client github.com/koordinator-sh/koordinator/apis \
- "config:v1alpha1 slo:v1alpha1 scheduling:v1alpha1 quota:v1alpha1" \
- --output-base "${TEMP_DIR}" \
- --go-header-file hack/boilerplate/boilerplate.go.txt
-
-${SCRIPT_ROOT}/hack/generate-internal-groups.sh \
-  "deepcopy,conversion,defaulter" \
-  github.com/koordinator-sh/koordinator/pkg/scheduler/apis/generated \
-  github.com/koordinator-sh/koordinator/pkg/scheduler/apis \
-  github.com/koordinator-sh/koordinator/pkg/scheduler/apis \
-  "config:v1beta2" \
-  --output-base "${TEMP_DIR}" \
-  --go-header-file hack/boilerplate/boilerplate.go.txt
-
-${SCRIPT_ROOT}/hack/generate-internal-groups.sh \
-  "deepcopy,conversion,defaulter" \
-  github.com/koordinator-sh/koordinator/pkg/descheduler/apis/generated \
-  github.com/koordinator-sh/koordinator/pkg/descheduler/apis \
-  github.com/koordinator-sh/koordinator/pkg/descheduler/apis \
-  "config:v1alpha2" \
-  --output-base "${TEMP_DIR}" \
-  --go-header-file hack/boilerplate/boilerplate.go.txt
+
+crdGenerators=("client" "informer" "lister")
+
+for generator in "${crdGenerators[@]}"; do
+  $SCRIPT_ROOT/hack/generate-groups.sh "${generator}" \
+   github.com/koordinator-sh/koordinator/pkg/client github.com/koordinator-sh/koordinator/apis \
+   "config:v1alpha1 slo:v1alpha1 scheduling:v1alpha1 quota:v1alpha1" \
+   --output-base "${TEMP_DIR}" \
+   --go-header-file hack/boilerplate/boilerplate.go.txt &
+done
+
+configGenerators=("deepcopy" "conversion" "defaulter")
+
+for generator in "${configGenerators[@]}"; do
+  ${SCRIPT_ROOT}/hack/generate-internal-groups.sh \
+    "${generator}" \
+    github.com/koordinator-sh/koordinator/pkg/scheduler/apis \
+    github.com/koordinator-sh/koordinator/pkg/scheduler/apis \
+    github.com/koordinator-sh/koordinator/pkg/scheduler/apis \
+    "config:v1beta2" \
+    --output-base "${TEMP_DIR}" \
+    --go-header-file hack/boilerplate/boilerplate.go.txt &
+
+   ${SCRIPT_ROOT}/hack/generate-internal-groups.sh \
+     "${generator}" \
+     github.com/koordinator-sh/koordinator/pkg/descheduler/apis \
+     github.com/koordinator-sh/koordinator/pkg/descheduler/apis \
+     github.com/koordinator-sh/koordinator/pkg/descheduler/apis \
+     "config:v1alpha2" \
+     --output-base "${TEMP_DIR}" \
+     --go-header-file hack/boilerplate/boilerplate.go.txt &
+done
+
+wait
 
 # Copy everything back.
 cp -a "${TEMP_DIR}/${ROOT_PKG}/." "${SCRIPT_ROOT}/"

pkg/descheduler/utils/sorter/helper.go

@@ -24,10 +24,9 @@ import (
 
 // CompareFn compares p1 and p2 and returns:
 //
-//   -1 if p1 <  p2
-//    0 if p1 == p2
-//   +1 if p1 >  p2
-//
+//	-1 if p1 <  p2
+//	 0 if p1 == p2
+//	+1 if p1 >  p2
 type CompareFn func(p1, p2 *corev1.Pod) int
 
 // MultiSorter implements the Sort interface

pkg/koordlet/util/cold_page.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/koordlet/util/cold_page_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/koordlet/util/system/resctrl_linux_test.go

@@ -36,14 +36,14 @@ func Test_isResctrlAvailableByCpuInfo(t *testing.T) {
 
 	tests := []args{
 		{
-			name: "testResctrlEnable",
-			cpuInfoContents: "flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke avx512_vnni md_clear flush_l1d arch_capabilities",
+			name:               "testResctrlEnable",
+			cpuInfoContents:    "flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke avx512_vnni md_clear flush_l1d arch_capabilities",
 			expectIsCatFlagSet: true,
 			expectIsMbaFlagSet: true,
 		},
 		{
-			name: "testResctrlUnable",
-			cpuInfoContents: "flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid tsc_known_freq pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch cpuid_fault invpcid_single ibrs_enhanced tsc_adjust bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves wbnoinvd arat avx512vbmi pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq rdpid fsrm arch_capabilities",
+			name:               "testResctrlUnable",
+			cpuInfoContents:    "flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid tsc_known_freq pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch cpuid_fault invpcid_single ibrs_enhanced tsc_adjust bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves wbnoinvd arat avx512vbmi pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq rdpid fsrm arch_capabilities",
 			expectIsCatFlagSet: false,
 			expectIsMbaFlagSet: false,
 		},

pkg/util/sloconfig/validator.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/util/sloconfig/validator_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/plugins/sloconfig/checkers_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/plugins/sloconfig/cpu_burst_checker_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/plugins/sloconfig/resource_qos_checker_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/plugins/sloconfig/resource_threshold_checker_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/plugins/sloconfig/slo_config_plugin_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/plugins/sloconfig/system_config_checker_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/cm/validating/validating_handler_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/node/plugins/sloconfig/slo_plugin_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/node/validating/validating_handler_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/webhook/util/writer/atomic/atomic_writer.go

@@ -85,15 +85,18 @@ const (
 // The Write algorithm is:
 //
 //  1. The payload is validated; if the payload is invalid, the function returns
-//  2. The current timestamped directory is detected by reading the data directory
+//     2. The current timestamped directory is detected by reading the data directory
 //     symlink
+//
 //  3. The old version of the volume is walked to determine whether any
 //     portion of the payload was deleted and is still present on disk.
+//
 //  4. The data in the current timestamped directory is compared to the projected
 //     data to determine if an update is required.
-//  5. A new timestamped dir is created
+//     5. A new timestamped dir is created
+//
 //  6. The payload is written to the new timestamped directory
-//  7. Symlinks and directory for new user-visible files are created (if needed).
+//     7. Symlinks and directory for new user-visible files are created (if needed).
 //     For example, consider the files:
 //     <target-dir>/podName
 //     <target-dir>/user/labels
@@ -107,9 +110,10 @@ const (
 //     The data directory itself is a link to a timestamped directory with
 //     the real data:
 //     <target-dir>/..data          -> ..2016_02_01_15_04_05.12345678/
-//  8. A symlink to the new timestamped directory ..data_tmp is created that will
+//     8. A symlink to the new timestamped directory ..data_tmp is created that will
 //     become the new data directory
-//  9. The new data directory symlink is renamed to the data directory; rename is atomic
+//     9. The new data directory symlink is renamed to the data directory; rename is atomic
+//
 // 10. Old paths are removed from the user-visible portion of the target directory
 // 11. The previous timestamped directory is removed, if it exists
 func (w *Writer) Write(payload map[string]FileProjection) error {