Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimize make generate and update to go 1.19 #1698

Closed
wants to merge 1 commit into from

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 8, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yihuifeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @yihuifeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eahydra
Copy link
Member Author

eahydra commented Oct 8, 2023

/hold

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (d04f86b) 65.93% compared to head (763ffbf) 65.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
- Coverage   65.93%   65.88%   -0.05%     
==========================================
  Files         384      384              
  Lines       41474    41557      +83     
==========================================
+ Hits        27344    27378      +34     
- Misses      12106    12146      +40     
- Partials     2024     2033       +9     
Flag Coverage Δ
unittests 65.88% <58.75%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/descheduler/utils/sorter/helper.go 73.58% <ø> (-7.55%) ⬇️
pkg/koordlet/util/cold_page.go 100.00% <ø> (ø)
pkg/scheduler/plugins/reservation/cache.go 84.74% <100.00%> (+0.62%) ⬆️
pkg/scheduler/plugins/reservation/plugin.go 76.19% <100.00%> (+0.16%) ⬆️
pkg/util/sloconfig/validator.go 80.76% <ø> (ø)
pkg/util/reservation/reservation.go 59.94% <81.25%> (+1.18%) ⬆️
pkg/scheduler/frameworkext/reservation_info.go 30.58% <25.80%> (+0.63%) ⬆️
pkg/scheduler/plugins/reservation/transformer.go 58.89% <53.16%> (-5.63%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -85,15 +85,18 @@ const (
// The Write algorithm is:
//
// 1. The payload is validated; if the payload is invalid, the function returns
// 2. The current timestamped directory is detected by reading the data directory
// 2. The current timestamped directory is detected by reading the data directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1和2之间可能需要换行,不然go fmt就会把第二行缩进

@eahydra eahydra closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants