[RFR] Fix JF for Actions in Task Manager Page

cypress/e2e/models/migration/task-manager/task-manager.ts

@@ -67,12 +67,12 @@ export class TaskManager {
     }
 
     private static getTaskRow(
-        application: string,
+        applicationName: string,
         kind: TaskKind
     ): Cypress.Chainable<JQuery<HTMLTableRowElement>> {
         return cy
             .get(trTag)
-            .filter(':contains("' + application + '")')
+            .filter(':contains("' + applicationName + '")')
             .filter(':contains("' + kind + '")');
     }
 
@@ -91,17 +91,27 @@ export class TaskManager {
         cy.wait(2 * SEC);
     }
 
-    public static setPreemption(preemption: boolean): void {
+    public static setPreemption(
+        applicationName: string,
+        kind: TaskKind,
+        preemption: boolean
+    ): void {
         const setPreemption = preemption === true ? "Enable preemption" : "Disable preemption";
         TaskManager.open();
-        cy.contains("Pending")
-            .closest(trTag)
-            .within(() => {
-                click(sideKebabMenu);
-            });
+        TaskManager.getTaskRow(applicationName, kind).find(sideKebabMenu).click();
         cy.get(actionMenuItem).contains(setPreemption).click();
     }
 
+    public static verifyPreemption(
+        applicationName: string,
+        kind: TaskKind,
+        preemption: boolean
+    ): void {
+        TaskManager.getTaskRow(applicationName, kind)
+            .find(TaskManagerColumns.preemption, { timeout: 10 * MIN })
+            .should("contain.text", preemption);
+    }
+
     public static cancelTask(status: string): void {
         TaskManager.open();
         cy.contains(status)

cypress/e2e/tests/migration/task-manager/miscellaneous.test.ts

@@ -18,18 +18,24 @@ limitations under the License.
 import {
     checkSuccessAlert,
     deleteApplicationTableRows,
+    deleteCustomResource,
+    getCommandOutput,
+    getNamespace,
     getRandomAnalysisData,
     getRandomApplicationData,
+    limitPodsByQuota,
     login,
     validateTextPresence,
 } from "../../../../utils/utils";
 import { Analysis } from "../../../models/migration/applicationinventory/analysis";
 import { TaskManager } from "../../../models/migration/task-manager/task-manager";
+import { TaskKind } from "../../../types/constants";
 import * as commonView from "../../../views/common.view";
 import { TaskManagerColumns } from "../../../views/taskmanager.view";
 
 describe(["@tier2"], "Actions in Task Manager Page", function () {
-    const applicationsList: Analysis[] = [];
+    const applicationsList: Array<Analysis> = [];
+    let bookServerApp: Analysis;
 
     before("Login", function () {
         login();
@@ -45,31 +51,37 @@ describe(["@tier2"], "Actions in Task Manager Page", function () {
         });
     });
 
-    it("Test Enable and Disable Premeption", function () {
-        const bookServerApp = new Analysis(
-            getRandomApplicationData("TaskApp1_", {
-                sourceData: this.appData["bookserver-app"],
-            }),
-            getRandomAnalysisData(this.analysisData["analysis_for_openSourceLibraries"])
-        );
-        bookServerApp.create();
-        TaskManager.setPreemption(true);
-        checkSuccessAlert(commonView.infoAlertMessage, "Update request submitted.");
-        validateTextPresence(TaskManagerColumns.preemption, "true");
-        TaskManager.setPreemption(false);
+    it("Limit pods to the number of tackle pods + 1", function () {
+        let namespace = getNamespace();
+        let command = `oc get pod --no-headers -n ${namespace} | grep -v task | grep -v Completed | wc -l`;
+        getCommandOutput(command).then((output) => {
+            let podsNumber = Number(output.stdout) + 1;
+            limitPodsByQuota(podsNumber);
+        });
+    });
+
+    it("Test Enable and Disable Preemption", function () {
+        for (let i = 0; i < 2; i++) {
+            bookServerApp = new Analysis(
+                getRandomApplicationData("TaskApp1_", {
+                    sourceData: this.appData["bookserver-app"],
+                }),
+                getRandomAnalysisData(this.analysisData["analysis_for_openSourceLibraries"])
+            );
+            bookServerApp.create();
+            applicationsList.push(bookServerApp);
+        }
+        TaskManager.setPreemption(applicationsList[1].name, TaskKind.languageDiscovery, true);
         checkSuccessAlert(commonView.infoAlertMessage, "Update request submitted.");
-        validateTextPresence(TaskManagerColumns.preemption, "false");
+        TaskManager.verifyPreemption(applicationsList[1].name, TaskKind.languageDiscovery, true);
+        TaskManager.setPreemption(applicationsList[1].name, TaskKind.languageDiscovery, false);
+        checkSuccessAlert(commonView.infoAlertMessage, "Update request submitted.", true);
+        TaskManager.verifyPreemption(applicationsList[1].name, TaskKind.languageDiscovery, false);
     });
 
     it("Cancel Task", function () {
-        const bookServerApp = new Analysis(
-            getRandomApplicationData("TaskApp1_", {
-                sourceData: this.appData["bookserver-app"],
-            }),
-            getRandomAnalysisData(this.analysisData["analysis_for_openSourceLibraries"])
-        );
-        bookServerApp.create();
-        TaskManager.cancelTask("Pending");
+        Analysis.analyzeAll(bookServerApp);
+        TaskManager.cancelTask("Postponed");
         checkSuccessAlert(commonView.infoAlertMessage, "Cancelation request submitted");
         validateTextPresence(TaskManagerColumns.status, "Canceled");
         TaskManager.cancelTask("Running");
@@ -78,4 +90,9 @@ describe(["@tier2"], "Actions in Task Manager Page", function () {
         // Succeeded tasks cannot be cancelled.
         TaskManager.cancelTask("Succeeded");
     });
+
+    after("Perform test data clean up", function () {
+        deleteCustomResource("quota", "task-pods");
+        deleteApplicationTableRows();
+    });
 });

cypress/fixtures/custom-resource.json

@@ -0,0 +1,3 @@
+{
+    "resourceQuota": "cypress/fixtures/yaml/resource-quota.yaml"
+}

cypress/fixtures/yaml/resource-quota.yaml

@@ -0,0 +1,8 @@
+---
+apiVersion: v1
+kind: ResourceQuota
+metadata:
+  name: task-pods
+spec:
+  hard:
+    pods: "${PODS_NUMBER}"

cypress/utils/utils.ts

@@ -2018,3 +2018,23 @@ export function downloadTaskDetails(format = downloadFormatDetails.yaml) {
         }
     });
 }
+
+export function limitPodsByQuota(podsNumber: number) {
+    let namespace = getNamespace();
+    cy.fixture("custom-resource").then((cr) => {
+        let manifast = cr["resourceQuota"];
+        let command = `PODS_NUMBER=${podsNumber} envsubst < ${manifast} | oc apply -f - -n ${namespace}`;
+        // let command = `export PODS_COUNT=6; oc apply -f ${manifast} -n${namespace}`;
+        getCommandOutput(command).then((output) => {
+            expect(output.stdout).to.equal("resourcequota/task-pods created");
+        });
+    });
+}
+
+export function deleteCustomResource(resourceType: string, resourceName: string) {
+    let namespace = getNamespace();
+    let command = `oc delete ${resourceType} ${resourceName} -n${namespace}`;
+    getCommandOutput(command).then((output) => {
+        expect(output.code).to.equal(0);
+    });
+}