Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix JF for Actions in Task Manager Page #1318

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

mguetta1
Copy link
Contributor

@mguetta1 mguetta1 commented Jan 23, 2025

Resolves: https://issues.redhat.com/browse/MTA-4387

  • Run bulk analysis so there will be tasks in Pending and Running state
  • Limit pods before testing enable and disable preemption
  • Ensure a task with the desired status exists before canceling

Jenkins run: https://jenkins-csb-migrationqe-main.dno.corp.redhat.com/view/Konveyor/job/mta/job/tackle-ui-tests-pr-tester/view/change-requests/job/PR-1318/10/console

@mguetta1 mguetta1 changed the title [WIP] Fix JF for Actions in Task Manager Page [RFR] Fix JF for Actions in Task Manager Page Jan 23, 2025
@mguetta1 mguetta1 requested review from sshveta and abrugaro January 23, 2025 20:56
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpick comment, all those variables that you are assigning only once, can be declared as const

Signed-off-by: Maayan Hadasi <[email protected]>
@mguetta1 mguetta1 requested review from abrugaro and nachandr January 27, 2025 15:28
@sshveta sshveta merged commit eb893bc into konveyor:main Jan 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants