[WIP] chore: restructure CLI init and begin logging refactor #2350
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package cluster | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "io" | ||
| "net/http" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| apiTypes "github.com/konstructio/kubefirst-api/pkg/types" | ||
| ) | ||
|
|
||
| type mockHTTPClient struct { | ||
| DoFunc func(req *http.Request) (*http.Response, error) | ||
| } | ||
|
|
||
| func (m *mockHTTPClient) Do(req *http.Request) (*http.Response, error) { | ||
| return m.DoFunc(req) | ||
| } | ||
|
|
||
| func TestClusterClient_CreateCluster(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| cluster apiTypes.ClusterDefinition | ||
| mockResp *http.Response | ||
| mockErr error | ||
| wantErr bool | ||
| errContains string | ||
| }{ | ||
| { | ||
| name: "successful cluster creation", | ||
| cluster: apiTypes.ClusterDefinition{ | ||
| ClusterName: "test-cluster", | ||
| }, | ||
| mockResp: &http.Response{ | ||
| StatusCode: http.StatusAccepted, | ||
| Body: io.NopCloser(bytes.NewReader([]byte(`{"status":"accepted"}`))), | ||
| }, | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "error - unexpected status code", | ||
| cluster: apiTypes.ClusterDefinition{ | ||
| ClusterName: "test-cluster", | ||
| }, | ||
| mockResp: &http.Response{ | ||
| StatusCode: http.StatusBadRequest, | ||
| Status: "400 Bad Request", | ||
| Body: io.NopCloser(bytes.NewReader([]byte(`{"error":"bad request"}`))), | ||
| }, | ||
| wantErr: true, | ||
| errContains: "unexpected status code", | ||
| }, | ||
| { | ||
| name: "error - failed to make request", | ||
| cluster: apiTypes.ClusterDefinition{ | ||
| ClusterName: "test-cluster", | ||
| }, | ||
| mockErr: http.ErrHandlerTimeout, | ||
| wantErr: true, | ||
| errContains: "failed to execute request", | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| mockClient := &mockHTTPClient{ | ||
| DoFunc: func(req *http.Request) (*http.Response, error) { | ||
| if tt.mockErr != nil { | ||
| return nil, tt.mockErr | ||
| } | ||
| return tt.mockResp, nil | ||
| }, | ||
| } | ||
|
|
||
| c := &ClusterClient{ | ||
| hostURL: "http://test.local", | ||
| httpClient: mockClient, | ||
| } | ||
|
|
||
| err := c.CreateCluster(tt.cluster) | ||
| if (err != nil) != tt.wantErr { | ||
| t.Errorf("CreateCluster() error = %v, wantErr %v", err, tt.wantErr) | ||
| return | ||
| } | ||
|
|
||
| if tt.wantErr && !strings.Contains(err.Error(), tt.errContains) { | ||
| t.Errorf("CreateCluster() error = %v, should contain %v", err, tt.errContains) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something that needs change but don't forget there's a whole
httptestpackage that adds support for mocking stuff out of the box (including http requests and responses).See here for reference: https://github.com/konstructio/dropkick/blob/main/internal/civo/sdk/json/json_fetch_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. This was from the robot and I haven't got back to this yet.