[WIP] chore: restructure CLI init and begin logging refactor #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
* add logger interface * add error logging * add utility for making k1 directory that returns an error Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
Signed-off-by: nathan-nicholson <[email protected]>
| apiTypes "github.com/konstructio/kubefirst-api/pkg/types" | ||
| ) | ||
|
|
||
| type mockHTTPClient struct { |
There was a problem hiding this comment.
Not something that needs change but don't forget there's a whole httptest package that adds support for mocking stuff out of the box (including http requests and responses).
See here for reference: https://github.com/konstructio/dropkick/blob/main/internal/civo/sdk/json/json_fetch_test.go
There was a problem hiding this comment.
Good call. This was from the robot and I haven't got back to this yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very WIP stab at refactoring the foundation of how dependencies such as logging and message printing are handled by commands.
Related Issue(s)
Fixes #
How to test