Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHTAPREL-717): use new PipelineRun builder #313

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

davidmogar
Copy link
Collaborator

This commit uses the new builder to generate the managed PipelineRun.

Signed-off-by: David Moreno García [email protected]

Depends on #310, #311 and #312

@davidmogar davidmogar requested review from a team, theflockers, ralphbean, mmalina, scoheb, gbenhaim, cuipinghuo and happybhati and removed request for a team November 30, 2023 13:02
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.7% 1.7% Duplication

Copy link

openshift-ci bot commented Feb 22, 2024

New changes are detected. LGTM label has been removed.

@johnbieren
Copy link
Collaborator

/test release-service-e2e

@johnbieren
Copy link
Collaborator

Blocked by konflux-ci/e2e-tests#1055

@jinqi7
Copy link
Contributor

jinqi7 commented Feb 26, 2024

/retest

1 similar comment
@jinqi7
Copy link
Contributor

jinqi7 commented Feb 26, 2024

/retest

This commit uses the new builder to generate the managed PipelineRun.

Signed-off-by: David Moreno García <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@kasemAlem
Copy link
Contributor

/retest

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.98%. Comparing base (d88b0bf) to head (50c7c7b).
Report is 5 commits behind head on main.

Files Patch % Lines
controllers/release/adapter.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   85.61%   84.98%   -0.63%     
==========================================
  Files          30       29       -1     
  Lines        1703     1645      -58     
==========================================
- Hits         1458     1398      -60     
- Misses        169      170       +1     
- Partials       76       77       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants