Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RHTAPREL-815): pass RSC to managed pipelinerun #367

Closed
wants to merge 3 commits into from
Closed

feat(RHTAPREL-815): pass RSC to managed pipelinerun #367

wants to merge 3 commits into from

Conversation

johnbieren
Copy link
Collaborator

Depends on #313

davidmogar and others added 3 commits February 13, 2024 15:25
@davidmogar
feat(RHTAPREL-714): add Tekton utilities
99f1fe2 
The utilities added in this commit come from the shared-utils
repository. In addition, the RPA already references the new
Pipeline struct.

Signed-off-by: David Moreno García <[email protected]>
@davidmogar
feat(RHTAPREL-717): use new PipelineRun builder
bdf97ac 
This commit uses the new builder to generate the managed PipelineRun.

Signed-off-by: David Moreno García <[email protected]>
@johnbieren
feat(RHTAPREL-815): pass RSC to managed pipelinerun
c81f111 
Signed-off-by: Johnny Bieren <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4c30242) 83.92% compared to head (c81f111) 84.91%.
Report is 17 commits behind head on main.

Files Patch % Lines
controllers/release/adapter.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   83.92%   84.91%   +0.99%     
==========================================
  Files          30       29       -1     
  Lines        1959     1564     -395     
==========================================
- Hits         1644     1328     -316     
+ Misses        244      164      -80     
- Partials       71       72       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinqi7 jinqi7 mentioned this pull request Feb 26, 2024
Merged
9 tasks
@johnbieren johnbieren marked this pull request as ready for review February 26, 2024 18:37
@johnbieren johnbieren closed this Feb 26, 2024
@johnbieren johnbieren requested a review from a team as a code owner February 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnbieren @openshift-merge-robot @davidmogar