Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RHTAPREL-715): rename PipelineRun references #310

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

davidmogar
Copy link
Collaborator

Rename references to the release Pipeline{Run} to managed Pipeline{Run}.

mmalina
mmalina previously approved these changes Nov 30, 2023
@scoheb
Copy link
Collaborator

scoheb commented Nov 30, 2023

Can we consider Release -> managed Release and tenant Release pipelines?

@davidmogar
Copy link
Collaborator Author

Can we consider Release -> managed Release and tenant Release pipelines?

In some cases I talk about Release Pipelines or Release PipelineRuns. That is, managed, tenant and post release Pipelines or PipelineRuns.

Does this answer your question?

@scoheb
Copy link
Collaborator

scoheb commented Nov 30, 2023

Can we consider Release -> managed Release and tenant Release pipelines?

In some cases I talk about Release Pipelines or Release PipelineRuns. That is, managed, tenant and post release Pipelines or PipelineRuns.

Does this answer your question?

I am referring to: https://github.com/redhat-appstudio/release-service/pull/310/files#r1410721270

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ecdf5b) 83.98% compared to head (5d4a501) 83.98%.
Report is 1 commits behind head on main.

Files Patch % Lines
loader/loader_mock.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files          29       29           
  Lines        1742     1742           
=======================================
  Hits         1463     1463           
  Misses        211      211           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rename references to the release Pipeline{Run} to managed
Pipeline{Run}.

Signed-off-by: David Moreno García <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants