Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXUI-188): disable pipeline actions for contributors #38

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

CryptoRodeo
Copy link
Contributor

@CryptoRodeo CryptoRodeo marked this pull request as ready for review November 25, 2024 20:29
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (850c442) to head (d46d8c3).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/ComponentDetails/ComponentDetailsView.tsx 50.00% 1 Missing ⚠️
src/components/WhatsNext/useWhatsNextItems.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   79.61%   79.61%   -0.01%     
==========================================
  Files         564      564              
  Lines       20991    20999       +8     
  Branches     5200     4953     -247     
==========================================
+ Hits        16712    16718       +6     
- Misses       4254     4257       +3     
+ Partials       25       24       -1     
Flag Coverage Δ
unittests 79.61% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CryptoRodeo
Copy link
Contributor Author

/retest

@CryptoRodeo
Copy link
Contributor Author

Looking at code coverage, I believe it can be ignored. It looks like it's referencing things outside of this patch, for example: https://app.codecov.io/gh/konflux-ci/konflux-ui/pull/38/blob/src/components/Components/ComponentDetails/ComponentDetailsView.tsx#L60

@CryptoRodeo CryptoRodeo requested a review from sahil143 December 2, 2024 19:47
@CryptoRodeo CryptoRodeo added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2024
@CryptoRodeo CryptoRodeo added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2024
@CryptoRodeo CryptoRodeo added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2024
@CryptoRodeo CryptoRodeo added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2024
@sahil143 sahil143 merged commit 68500b3 into konflux-ci:main Dec 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants