fix(KFLUXUI-188): disable pipeline actions for contributors

konflux-ci · Nov 22, 2024 · 668a1ae · 668a1ae
1 parent 06ab0bb
commit 668a1ae
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 17 deletions.
diff --git a/src/components/ApplicationDetails/ApplicationDetails.tsx b/src/components/ApplicationDetails/ApplicationDetails.tsx
@@ -9,6 +9,7 @@ import { TrackEvents, useTrackEvent } from '../../utils/analytics';
 import { useApplicationBreadcrumbs } from '../../utils/breadcrumb-utils';
 import { useAccessReviewForModel } from '../../utils/rbac';
 import { useComponentRelationAction } from '../ComponentRelation/useComponentRelationAction';
+import { createCustomizeAllPipelinesModalLauncher } from '../CustomizedPipeline/CustomizePipelinesModal';
 import DetailsPage from '../DetailsPage/DetailsPage';
 import { useModalLauncher } from '../modal/ModalProvider';
 import { applicationDeleteModal } from '../modal/resource-modals';
@@ -22,6 +23,7 @@ export const ApplicationDetails: React.FC<React.PropsWithChildren> = () => {
   // const track = useTrackEvent();
   const { namespace, workspace } = useWorkspaceInfo();
   const [canCreateComponent] = useAccessReviewForModel(ComponentModel, 'create');
+  const [canPatchComponent] = useAccessReviewForModel(ComponentModel, 'patch');
   const [canCreateIntegrationTest] = useAccessReviewForModel(
     IntegrationTestScenarioModel,
     'create',
@@ -77,8 +79,10 @@ export const ApplicationDetails: React.FC<React.PropsWithChildren> = () => {
                 app_name: applicationName,
                 workspace,
               });
-              // showModal(createCustomizeAllPipelinesModalLauncher(applicationName, namespace));
+              showModal(createCustomizeAllPipelinesModalLauncher(applicationName, namespace));
             },
+            disabledTooltip: 'You do not have access to manage build pipelines',
+            isDisabled: !canPatchComponent,
             key: 'manage-build-pipelines',
             label: 'Manage build pipelines',
           },

diff --git a/src/components/Components/ComponentDetails/ComponentDetailsView.tsx b/src/components/Components/ComponentDetails/ComponentDetailsView.tsx
@@ -1,30 +1,24 @@
 import React from 'react';
 import { useNavigate, useParams } from 'react-router-dom';
-import {
-  Bullseye,
-  Button,
-  ButtonVariant,
-  Spinner,
-  Text,
-  TextVariants,
-} from '@patternfly/react-core';
+import { Bullseye, ButtonVariant, Spinner, Text, TextVariants } from '@patternfly/react-core';
 import isFunction from 'lodash/isFunction';
 import isObject from 'lodash/isObject';
 import pipelineImg from '../../../assets/Pipeline.svg';
 import { useComponent } from '../../../hooks/useComponents';
 import { HttpError } from '../../../k8s/error';
-import { ComponentGroupVersionKind } from '../../../models';
+import { ComponentGroupVersionKind, ComponentModel } from '../../../models';
 import { RouterParams } from '../../../routes/utils';
 import ErrorEmptyState from '../../../shared/components/empty-state/ErrorEmptyState';
 import { useApplicationBreadcrumbs } from '../../../utils/breadcrumb-utils';
+import { useAccessReviewForModel } from '../../../utils/rbac';
+import { ButtonWithAccessTooltip } from '../../ButtonWithAccessTooltip';
 import { createCustomizeComponentPipelineModalLauncher } from '../../CustomizedPipeline/CustomizePipelinesModal';
 import { DetailsPage } from '../../DetailsPage';
 import { Action } from '../../DetailsPage/types';
 import { GettingStartedCard } from '../../GettingStartedCard/GettingStartedCard';
 import { useModalLauncher } from '../../modal/ModalProvider';
 import { useWorkspaceInfo } from '../../Workspace/useWorkspaceInfo';
 import { useComponentActions } from '../component-actions';
-
 import './ComponentDetailsView.scss';
 
 export const COMPONENTS_GS_LOCAL_STORAGE_KEY = 'components-getting-started-modal';
@@ -36,6 +30,7 @@ const ComponentDetailsView: React.FC = () => {
   const applicationBreadcrumbs = useApplicationBreadcrumbs();
   const showModal = useModalLauncher();
   const [component, loaded, componentError] = useComponent(namespace, workspace, componentName);
+  const [canPatchComponent] = useAccessReviewForModel(ComponentModel, 'patch');
 
   const componentActions = useComponentActions(loaded ? component : undefined, componentName);
   const actions: Action[] = React.useMemo(
@@ -96,9 +91,11 @@ const ComponentDetailsView: React.FC = () => {
               Using the Advanced or Custom build pipeline, you can enable all additional tasks for
               added security.
             </div>
-            <Button
+            <ButtonWithAccessTooltip
               className="pf-u-mt-xl"
               variant={ButtonVariant.secondary}
+              isDisabled={!canPatchComponent}
+              tooltip="You don't have access to edit the build pipeline plan"
               onClick={() =>
                 showModal(
                   createCustomizeComponentPipelineModalLauncher(
@@ -109,7 +106,7 @@ const ComponentDetailsView: React.FC = () => {
               }
             >
               Edit build pipeline plan
-            </Button>
+            </ButtonWithAccessTooltip>
           </GettingStartedCard>
         }
         breadcrumbs={[

diff --git a/src/components/Components/ComponentsListView/ComponentListView.tsx b/src/components/Components/ComponentsListView/ComponentListView.tsx
@@ -5,7 +5,6 @@ import {
   AlertActionCloseButton,
   AlertActionLink,
   AlertVariant,
-  Button,
   ButtonVariant,
   EmptyStateBody,
   Flex,
@@ -64,6 +63,7 @@ const ComponentListView: React.FC<React.PropsWithChildren<ComponentListViewProps
     applicationName,
   );
   const [canCreateComponent] = useAccessReviewForModel(ComponentModel, 'create');
+  const [canPatchComponent] = useAccessReviewForModel(ComponentModel, 'patch');
 
   const showModal = useModalLauncher();
 
@@ -177,20 +177,22 @@ const ComponentListView: React.FC<React.PropsWithChildren<ComponentListViewProps
             complete control over them.
           </FlexItem>
           <FlexItem>
-            <Button
+            <ButtonWithAccessTooltip
               className="pf-u-mr-2xl"
               variant={ButtonVariant.secondary}
+              isDisabled={!canPatchComponent}
+              tooltip="You don't have access to edit the build pipeline plans"
               onClick={() =>
                 showModal(createCustomizeAllPipelinesModalLauncher(applicationName, namespace))
               }
             >
               Edit build pipeline plans
-            </Button>
+            </ButtonWithAccessTooltip>
           </FlexItem>
         </Flex>
       </GettingStartedCard>
     ),
-    [applicationName, namespace, showModal],
+    [applicationName, namespace, showModal, canPatchComponent],
   );
 
   return (

diff --git a/src/components/Components/component-actions.tsx b/src/components/Components/component-actions.tsx
@@ -31,6 +31,8 @@ export const useComponentActions = (component: ComponentKind, name: string): Act
           ),
         id: 'manage-build-pipeline',
         label: 'Edit build pipeline plan',
+        disabled: !canPatchComponent,
+        disabledTooltip: "You don't have access to edit the build pipeline plan",
         analytics: {
           link_name: 'manage-build-pipeline',
           link_location: 'component-list',

diff --git a/src/components/WhatsNext/useWhatsNextItems.ts b/src/components/WhatsNext/useWhatsNextItems.ts
@@ -17,6 +17,7 @@ export const useWhatsNextItems = (applicationName: string) => {
   const { workspace, namespace } = useWorkspaceInfo();
   const { url: githubAppURL } = useApplicationPipelineGitHubApp();
   const [canCreateComponent] = useAccessReviewForModel(ComponentModel, 'create');
+  const [canPatchComponent] = useAccessReviewForModel(ComponentModel, 'patch');
   const [canCreateIntegrationTest] = useAccessReviewForModel(
     IntegrationTestScenarioModel,
     'create',
@@ -122,6 +123,8 @@ export const useWhatsNextItems = (applicationName: string) => {
         'Add some automation by upgrading your default build pipelines to custom build pipelines.',
       icon: pipelineIcon,
       cta: {
+        disabled: !canPatchComponent,
+        disabledTooltip: "You don't have access to manage build pipelines",
         label: 'Manage build pipelines',
         onClick: () =>
           showModal(createCustomizeAllPipelinesModalLauncher(applicationName, namespace)),