Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tool programming interface pointer in kp_sampler_skip.cpp and kp_core.hpp #247

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Remove tool programming interface pointer in kp_sampler_skip.cpp and kp_core.hpp #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25c0d65
kp_core.hpp: remove pointer from ptpi
vlkale Apr 1, 2024
152bf84
kp_sampler_skip.cpp: pass by value kokkosp_p_t_p_i
vlkale Apr 1, 2024
2839954
kp_sampler_skip.cpp: remove dereference assignment for ptpi callback
vlkale Apr 1, 2024
bac317d
kp_core.hpp: apply clang-format
vlkale Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/kokkos-sampler/kp_sampler_skip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ void invoke_ktools_fence(uint32_t devID) {
}

void kokkosp_provide_tool_programming_interface(
uint32_t num_funcs, Kokkos_Tools_ToolProgrammingInterface* funcsFromTPI) {
uint32_t num_funcs, Kokkos_Tools_ToolProgrammingInterface funcsFromTPI) {
if (!num_funcs) {
if (tool_verbosity > 0)
printf(
"KokkosP: Note: Number of functions in Tools Programming Interface "
"is 0!\n");
}
tpi_funcs = *funcsFromTPI;
tpi_funcs = funcsFromTPI;
}

void kokkosp_init_library(const int loadSeq, const uint64_t interfaceVer,
Expand Down
2 changes: 1 addition & 1 deletion profiling/all/kp_core.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ using Kokkos::Tools::SpaceHandle;
#define EXPOSE_PROVIDE_TOOL_PROGRAMMING_INTERFACE(FUNC_NAME) \
__attribute__((weak)) void kokkosp_provide_tool_programming_interface( \
const uint32_t num_actions, \
Kokkos_Tools_ToolProgrammingInterface* ptpi) { \
Kokkos_Tools_ToolProgrammingInterface ptpi) { \
FUNC_NAME(num_actions, ptpi); \
}

Expand Down
Loading