Remove tool programming interface pointer in kp_sampler_skip.cpp and kp_core.hpp #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp_sampler_skip.cpp: last parameter should be passed by value rather than pointer in kokkosp_p_t_p_i
crtrott
approved these changes
Apr 4, 2024
dalg24
reviewed
Apr 4, 2024
@dalg24 Thanks. I put this in the description (fence function pointer is null - note this impacts the tools that use the tool-invoked fence which is currently just the sampler). |
masterleinad
reviewed
Apr 4, 2024
@masterleinad Thanks for bringing this up. I think that this is handled by that test for the sampler you helped me. That said, I can certainly add in a test case in the small chain of patches I have upcoming right now. The next one consists of the tests and I will put a matcher to check for the print of the fence being null. |
|
Modified the comment, we will have the test come in with the sampler thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kokkos Core interface passes the struct by value not by pointer.