Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaning(simple-kernel-timer): promote find_index to kp_shared.hpp #227

Merged
merged 1 commit into from
Dec 28, 2023
Merged

cleaning(simple-kernel-timer): promote find_index to kp_shared.hpp #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions profiling/simple-kernel-timer/kp_json_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,6 @@ inline void write_json(std::ostream& os, KernelPerformanceInfo const& kp,
os << indent << '}';
}

int find_index(std::vector<KernelPerformanceInfo*>& kernels,
const char* kernelName) {
for (unsigned int i = 0; i < kernels.size(); i++) {
KernelPerformanceInfo* nextKernel = kernels[i];

if (strcmp(nextKernel->getName(), kernelName) == 0) {
return i;
}
}

return -1;
}

int main(int argc, char* argv[]) {
if (argc == 1) {
fprintf(stderr, "Did you specify any data files on the command line!\n");
Expand Down
13 changes: 0 additions & 13 deletions profiling/simple-kernel-timer/kp_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,6 @@

using namespace KokkosTools::KernelTimer;

int find_index(std::vector<KernelPerformanceInfo*>& kernels,
const char* kernelName) {
for (unsigned int i = 0; i < kernels.size(); i++) {
KernelPerformanceInfo* nextKernel = kernels[i];

if (strcmp(nextKernel->getName(), kernelName) == 0) {
return i;
}
}

return -1;
}

int main(int argc, char* argv[]) {
if (argc == 1) {
fprintf(stderr, "Did you specify any data files on the command line!\n");
Expand Down
12 changes: 12 additions & 0 deletions profiling/simple-kernel-timer/kp_shared.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

#include <map>
#include <memory>
#include <vector>

#include "kp_kernel_info.h"

namespace KokkosTools::KernelTimer {
Expand All @@ -39,6 +41,16 @@ inline bool compareKernelPerformanceInfo(KernelPerformanceInfo* left,
return left->getTime() > right->getTime();
};

inline int find_index(const std::vector<KernelPerformanceInfo*>& kernels,
const char* kernelName) {
for (unsigned int i = 0; i < kernels.size(); i++) {
if (strcmp(kernels[i]->getName(), kernelName) == 0) {
return i;
}
}
return -1;
}

} // namespace KokkosTools::KernelTimer

#endif // _H_KOKKOSP_KERNEL_SHARED