cleaning(simple-kernel-timer): promote find_index to kp_shared.hpp

[romintomasetti]

As suggested by @masterleinad in #225.

[romintomasetti]

@masterleinad I have clang-format-14, not 8... So I don't know what changes are required... Do you know how we could make the action show a suggested diff in the action log? Thanks!

[masterleinad]

@masterleinad I have clang-format-14, not 8... So I don't know what changes are required... Do you know how we could make the action show a suggested diff in the action log? Thanks!

See #228.

[romintomasetti]

@dalg24 Could you have a look and merge if all is fine for you? Thanks !

[dalg24]

I see little benefit from changing the original implementation

Suggested change

	const auto it =
	std::find_if(kernels.begin(), kernels.end(), [&](const auto& kernel) {
	return strcmp(kernel->getName(), kernelName) == 0;
	});
	return it == kernels.cend() ? -1 : std::distance(kernels.begin(), it);
	for (unsigned int i = 0; i < kernels.size(); i++) {
	KernelPerformanceInfo* nextKernel = kernels[i];
	if (strcmp(nextKernel->getName(), kernelName) == 0) {
	return i;
	}
	}
	return -1;

[dalg24]

I meant to apply the suggestion and merge but somehow I don't see the option to do so in the GH interface.

[dalg24]

Suggested change

#include <algorithm>