Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Price sort by logic #10529

Closed
wants to merge 1 commit into from
Closed

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jun 22, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

❗️❗️ Needs kodadot/stick#285

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

@hassnian hassnian mentioned this pull request Jun 22, 2024
6 tasks
Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 309a524
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6676792609a64f00085689c1
😎 Deploy Preview https://deploy-preview-10529--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Jun 22, 2024

Code Climate has analyzed commit 309a524 and detected 0 issues on this pull request.

View more on Code Climate.

@exezbcz
Copy link
Member

exezbcz commented Jul 14, 2024

what is needed here to be finished?

@exezbcz
Copy link
Member

exezbcz commented Sep 18, 2024

i am a ping

@vikiival
Copy link
Member

cc @hassnian ?

@hassnian
Copy link
Contributor Author

hassnian commented Sep 21, 2024

what is needed here to be finished?

i am a ping

sorry for the late response , i did test but got busy with other issues

cc @hassnian ?

it's still showing unlisted nfts first with price_ASC_NULLS_LAST sort applied

@vikiival NULL LAST does nothing atm since unlisted nfts are saved as 0 not NULL , do we change this ?

I might be missing something

CleanShot 2024-09-21 at 14 34 31@2x

@vikiival
Copy link
Member

does nothing atm since unlisted nfts are saved as 0 not NULL , do we change this ?

can you open a PR please?
you need to update: mint, transfer, list functions

@hassnian
Copy link
Contributor Author

does nothing atm since unlisted nfts are saved as 0 not NULL , do we change this ?

can you open a PR please? you need to update: mint, transfer, list functions

sure

@hassnian
Copy link
Contributor Author

hassnian commented Oct 2, 2024

continue #11075

@hassnian hassnian closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price sort by logic
3 participants