Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unlisted nfts are saved as 0 not NULL #310

Closed
hassnian opened this issue Sep 24, 2024 · 1 comment · Fixed by #311
Closed

unlisted nfts are saved as 0 not NULL #310

hassnian opened this issue Sep 24, 2024 · 1 comment · Fixed by #311
Assignees
@hassnian

Comments

@hassnian
Copy link
Contributor

it's still showing unlisted nfts first with price_ASC_NULLS_LAST sort applied

@vikiival NULL LAST does nothing atm since unlisted nfts are saved as 0 not NULL , do we change this ?

I might be missing something

CleanShot 2024-09-21 at 14 34 31@2x

Originally posted by @hassnian in kodadot/nft-gallery#10529 (comment)

does nothing atm since unlisted nfts are saved as 0 not NULL , do we change this ?

can you open a PR please?
you need to update: mint, transfer, list functions

Originally posted by @vikiival in kodadot/nft-gallery#10529 (comment)
@hassnian hassnian self-assigned this Sep 24, 2024
@vikiival
Copy link
Member

Yes please replace 0 with null

@hassnian hassnian mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hassnian hassnian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unlisted nfts are saved as 0 not NULL kodadot/stick
2 participants
@vikiival @hassnian