-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10]: src: interstitial commit version (#1817) #1850
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #1850 +/- ##
=================================================
+ Coverage 49.78% 63.05% +13.27%
=================================================
Files 81 93 +12
Lines 11149 11968 +819
=================================================
+ Hits 5550 7546 +1996
+ Misses 5114 3737 -1377
- Partials 485 685 +200
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The Knative version is now included in version command verbose output Building an unreleased version no longer returns v0.0.0, but instead the value provided by `git describe --tags` which is the most recent tagged release with a suffix consisting of the number of commits since that release and the short hash. Verbose output now always includes the current commit on a dedicated line.
d914c01
to
42f3517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a backport of #1817 to the 1.10 branch.
The Knative version is now included in version command verbose output
Building an unreleased version no longer returns v0.0.0, but instead the value provided by
git describe --tags
which is the most recent tagged release with a suffix consisting of the number of commits since that release and the short hash.Verbose output now always includes the current commit on a dedicated line.