Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.9] Add func v1.10.0 #193

Merged

Conversation

dsimansk
Copy link

@dsimansk dsimansk commented Jul 3, 2023

This's a placeholder for the func from Serverless 1.29 release.

To update:

# According to whatever is available in func's midstream

$ go mod edit -replace knative.dev/func=github.com/openshift-knative/[email protected]

$ ./hack/update-deps.sh

# and commit everything

/cc @lance @rhuss

@openshift-ci openshift-ci bot requested a review from lance July 3, 2023 15:42
@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 3, 2023
@dsimansk dsimansk changed the title [release-v1.9] Add func v1.10.0 @dsimansk [release-v1.9] Add func v1.10.0 Jul 4, 2023
@dsimansk
Copy link
Author

dsimansk commented Jul 4, 2023

@lance I'll merge this one manually. There're steps in the top comment to update the func version. Also @Kaustubh-pande mentioned a new image that needs to be added to build flags, so unblocking this part as well.

@dsimansk dsimansk merged commit 4433dfe into openshift-knative:release-v1.9 Jul 4, 2023
@lance
Copy link

lance commented Jul 6, 2023

The image PR is here: #198

@lance
Copy link

lance commented Jul 6, 2023

@dsimansk I'm still trying to get knative/func#1850 /lgtm. Once that has landed I can kick off a 1.10.1 release upstream and a new PR for 1.30 can be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants