Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop maistra 2.3 from CI #1091

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Drop maistra 2.3 from CI #1091

merged 1 commit into from
Aug 14, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 14, 2023

As per title, this patch drops maistra 2.3 from CI.

2.4 was released and downstream also started testing with 2.4.

/kind cleanup

NONE

Docs

NONE

/cc @ReToCode @norbjd

@knative-prow knative-prow bot requested review from norbjd and ReToCode August 14, 2023 10:21
@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #1091 (660d704) into main (f9d534e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files          18       18           
  Lines        1430     1430           
=======================================
  Hits         1144     1144           
  Misses        229      229           
  Partials       57       57           

@nak3
Copy link
Contributor Author

nak3 commented Aug 14, 2023

2.4 was released and downstream also started testing with 2.4.

Not only for testing but also the the official image on 1.30.0 RC1 is also using 2.4.1.

$ skopeo inspect docker://registry.redhat.io/openshift-service-mesh/proxyv2-rhel8@sha256:a10e76aa15707e708f82c8d9e8b5179bf67780d99f3c3e2e99b84ae2a0aa4ecb |grep 2.4.1-3
        "2.4.1-3",
        "2.4.1-3-source",
        "url": "https://access.redhat.com/containers/#/registry.access.redhat.com/openshift-service-mesh/proxyv2-rhel8/images/2.4.1-3",

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit bd14fc6 into knative-extensions:main Aug 14, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants