Fix envoy deprecated fields

[norbjd]

Changes

• 🧹 Replace envoy deprecated fields

/kind cleanup

I've noticed some warning logs in the gateway, due to the use of deprecated fields of Envoy. The most problematic is the following one, related to HeaderValueOption.Append, who appears every time a new ingress is added/updated/deleted, making the gateway logs unreadable because of the noise:

[2023-07-22 14:01:08.253][1][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.core.v3.HeaderValueOption Using deprecated option 'envoy.config.core.v3.HeaderValueOption.append' from file base.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

I've replaced it with AppendAction, as Envoy docs states.

I've also seen these warning logs when gateway starts (related to google_re2 and exact_match in the bootstrap config:

[2023-07-22 15:04:43.553][1][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.type.matcher.v3.RegexMatcher Using deprecated option 'envoy.type.matcher.v3.RegexMatcher.google_re2' from file regex.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

[2023-07-22 15:04:43.553][1][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.route.v3.HeaderMatcher Using deprecated option 'envoy.config.route.v3.HeaderMatcher.exact_match' from file route_components.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

This Pull Request fixes all the warnings above. I've ran a random e2e test to check these warnings were not appearing anymore in the gateway logs.

Release Note

Fix deprecated Envoy fields

[codecov]

Codecov Report

Merging #1076 (8c3eae9) into main (c90234c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files          18       18           
  Lines        1430     1430           
=======================================
  Hits         1144     1144           
  Misses        229      229           
  Partials       57       57           

Files Changed	Coverage Δ
pkg/envoy/api/headers.go	100.00% <100.00%> (ø)

[norbjd]

Don't know why the CI failed with timeouts when running the e2e conformance tests using proxyv2-ubi8:2.3-latest 😢

[nak3]

Thank you for working on this and sorry for the late response. #1091 will drop maistra 2.3 so we can merge this.

[nak3]

/lgtm
/approve

[nak3]

/override "e2e tests (v1.25.x, quay.io/maistra-dev/proxyv2-ubi8:2.3-latest, plain)"

[knative-prow]

@nak3: nak3 unauthorized: /override is restricted to Repo administrators.

In response to this:

/override "e2e tests (v1.25.x, quay.io/maistra-dev/proxyv2-ubi8:2.3-latest, plain)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nak3]

@norbjd Sorry for bothering you but could you try to rebase this? I don't have a permission to ignore the CI error.

[nak3]

/lgtm
/approve

Thank you!

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, norbjd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nak3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[norbjd]

Should be good now, all tests are passing 🥳 thanks!