-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix envoy deprecated fields #1076
Fix envoy deprecated fields #1076
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 18 18
Lines 1430 1430
=======================================
Hits 1144 1144
Misses 229 229
Partials 57 57
|
Don't know why the CI failed with timeouts when running the e2e conformance tests using |
Thank you for working on this and sorry for the late response. #1091 will drop maistra 2.3 so we can merge this. |
/lgtm |
/override "e2e tests (v1.25.x, quay.io/maistra-dev/proxyv2-ubi8:2.3-latest, plain)" |
@nak3: nak3 unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@norbjd Sorry for bothering you but could you try to rebase this? I don't have a permission to ignore the CI error. |
/lgtm Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, norbjd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should be good now, all tests are passing 🥳 thanks! |
Changes
/kind cleanup
I've noticed some warning logs in the gateway, due to the use of deprecated fields of Envoy. The most problematic is the following one, related to
HeaderValueOption.Append
, who appears every time a new ingress is added/updated/deleted, making the gateway logs unreadable because of the noise:I've replaced it with
AppendAction
, as Envoy docs states.I've also seen these warning logs when gateway starts (related to
google_re2
andexact_match
in the bootstrap config:This Pull Request fixes all the warnings above. I've ran a random e2e test to check these warnings were not appearing anymore in the gateway logs.
Release Note