Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keyboard offset on iOS #695

Closed
wants to merge 22 commits into from
Closed

feat: keyboard offset on iOS #695

wants to merge 22 commits into from

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Nov 16, 2024 •
edited
Loading

📜 Description

💡 Motivation and Context

image

Closes #250

📢 Changelog

JS

iOS

Android

🤔 How Has This Been Tested?

📸 Screenshots (if appropriate):

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🍎 iOS iOS specific example Anything related to example project 👆 interactive keyboard Anything related to interactive keyboard dismissing 🚨 requires API changes 🚨 Changes that requires changes in library API labels Nov 16, 2024
@kirillzyusko kirillzyusko self-assigned this Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024 •
edited
Loading

📊 Package size report

Current size Target Size Difference
164817 bytes 161655 bytes 3162 bytes 📈

@kirillzyusko kirillzyusko added the documentation Improvements or additions to documentation label Nov 16, 2024
@kirillzyusko kirillzyusko force-pushed the feat/keyboard-offset-ios branch from b9603fc to f0e58d4 Compare November 16, 2024 10:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-26 15:06 UTC

@argos-ci Argos CI
Copy link

argos-ci bot commented Nov 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 31, 2024, 11:12 PM

@kirillzyusko kirillzyusko force-pushed the feat/keyboard-offset-ios branch from f0e58d4 to 0247535 Compare November 16, 2024 14:15
@kirillzyusko
feat: add basic fs structure for managing keyboard offset (just save …
efd6980 
…changes before macOS 14 -> macOS 15 update)🤞
@kirillzyusko
feat: more changes to actually move progress further
81d9846
@kirillzyusko
fix: lint, remove iav
ff7506d
@kirillzyusko
fix: iOS 16 incorrect height in onEnd event
c215689
@kirillzyusko
chore: update TODO
b90aaa9
@kirillzyusko
fix: grow of input breaks onInteractive handler
56116e4
@kirillzyusko
docs: document new API
32d8e4e
@kirillzyusko
fix: objc lint
82b0501
@kirillzyusko
fix: lint ts
7556b7b
@kirillzyusko
fix: platform inconsistency, fabric Android build
0b59cde
@kirillzyusko
fix: lint ts
ef6777a
@kirillzyusko
fix: fabric build
bd1ff10
@kirillzyusko
fix: suppress detekt violation
8cf282f
@kirillzyusko
fix: conflicts after rebasing to main
3e0876f
@kirillzyusko
fix: iOS unit tests
d701ee3
@kirillzyusko
fix: mock nativeID to pass iOS unit tests
4f5d77b
@kirillzyusko
fix: swiftformat
3846dc8
@kirillzyusko
refactor: create separate class to simplify KeyboardMovementObserver …
1d87523 
…implementation
@kirillzyusko kirillzyusko force-pushed the feat/keyboard-offset-ios branch from 157c97e to 1d87523 Compare November 24, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kirillzyusko kirillzyusko

Labels
documentation Improvements or additions to documentation example Anything related to example project 👆 interactive keyboard Anything related to interactive keyboard dismissing 🍎 iOS iOS specific 🚨 requires API changes 🚨 Changes that requires changes in library API
Projects
None yet
Milestone
No milestone
1 participant
@kirillzyusko