Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run xCode 16 on macos 15 #686

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Nov 13, 2024

📜 Description

An attempt to fix iOS 18 e2e tests.

💡 Motivation and Context

First of all I ahd to run e2e tests on macos-15 runner because of a recent changes introduced in actions/runner-images#10703

I did it, but then turned out, that macos-15 doesn't have iPhone 14 by default. I re-generated assets for iPhone 16 Pro, now e2e tests can start successfully, but for some reasons they don't want to pass - many of tests that rely on matching screenshots detects a difference. Unfortunately I can not detect the diff, because we exceed 90 minutes.

Taking all information above I decided, that current changes are good enough to be merged - later on I can restore iOS 18 e2e tests in CI, but tight now I want to unblock the process of merging other important PRs.

Also iOS 18 tests were not very stable. When I added them I used older macos and older iOS to generate screenshots. Now I updated to necessary XCode version, so I should be able to have 1:1 environment, let's see!

📢 Changelog

E2E

  • changed iPhone 14 to iPhone 16 Pro (to match previous versions);
  • regenerated assets;
  • lock simulator18 version;

CI

  • run iOS 18 tests on macos-15;
  • exclude iOS 18 testing from CI;

🤔 How Has This Been Tested?

Tested on CI.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🍎 iOS iOS specific CI CI (github actions) e2e Anything about E2E tests labels Nov 13, 2024
@kirillzyusko kirillzyusko self-assigned this Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

📊 Package size report

Current size Target Size Difference
159580 bytes 159580 bytes 0 bytes 📉

@kirillzyusko kirillzyusko marked this pull request as ready for review November 14, 2024 12:54
@kirillzyusko kirillzyusko merged commit 82628d5 into main Nov 14, 2024
13 checks passed
@kirillzyusko kirillzyusko deleted the fix/e2e-tests-new-gh-macos-policy branch November 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI (github actions) e2e Anything about E2E tests 🍎 iOS iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant