Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
An attempt to fix iOS 18 e2e tests.
💡 Motivation and Context
First of all I ahd to run e2e tests on
macos-15
runner because of a recent changes introduced in actions/runner-images#10703I did it, but then turned out, that
macos-15
doesn't have iPhone 14 by default. I re-generated assets for iPhone 16 Pro, now e2e tests can start successfully, but for some reasons they don't want to pass - many of tests that rely on matching screenshots detects a difference. Unfortunately I can not detect the diff, because we exceed 90 minutes.Taking all information above I decided, that current changes are good enough to be merged - later on I can restore iOS 18 e2e tests in CI, but tight now I want to unblock the process of merging other important PRs.
Also iOS 18 tests were not very stable. When I added them I used older macos and older iOS to generate screenshots. Now I updated to necessary XCode version, so I should be able to have 1:1 environment, let's see!
📢 Changelog
E2E
CI
🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist