-
-
Notifications
You must be signed in to change notification settings - Fork 85
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: run xCode 16 on macos 15 (#686)
## 📜 Description An attempt to fix iOS 18 e2e tests. ## 💡 Motivation and Context First of all I ahd to run e2e tests on `macos-15` runner because of a recent changes introduced in actions/runner-images#10703 I did it, but then turned out, that `macos-15` doesn't have iPhone 14 by default. I re-generated assets for iPhone 16 Pro, now e2e tests can start successfully, but for some reasons they don't want to pass - many of tests that rely on matching screenshots detects a difference. Unfortunately I can not detect the diff, because we exceed 90 minutes. Taking all information above I decided, that current changes are good enough to be merged - later on I can restore iOS 18 e2e tests in CI, but tight now I want to unblock the process of merging other important PRs. Also iOS 18 tests were not very stable. When I added them I used older macos and older iOS to generate screenshots. Now I updated to necessary XCode version, so I should be able to have 1:1 environment, let's see! <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### E2E - changed iPhone 14 to iPhone 16 Pro (to match previous versions); - regenerated assets; - lock simulator18 version; ### CI - run iOS 18 tests on macos-15; - exclude iOS 18 testing from CI; ## 🤔 How Has This Been Tested? Tested on CI. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
- Loading branch information
1 parent
1e48494
commit 82628d5
Showing
82 changed files
with
8 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-137 KB
e2e/kit/assets/ios/iPhone 14/AwareScrollViewDisabledStateKeyboardClosed.png
Binary file not shown.
Binary file removed
BIN
-170 KB
e2e/kit/assets/ios/iPhone 14/AwareScrollViewDisabledStateKeyboardOpened.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-137 KB
e2e/kit/assets/ios/iPhone 14/AwareScrollViewKeyboardClosedWithoutBackScroll.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-234 KB
e2e/kit/assets/ios/iPhone 14/AwareScrollViewTextSelectionChanged.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-252 KB
e2e/kit/assets/ios/iPhone 14/InteractiveKeyboardAfterGestureDown.png
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Oops, something went wrong.
Binary file added
BIN
+116 KB
e2e/kit/assets/ios/iPhone 16 Pro/AvoidingViewPackagePaddingInitial.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+145 KB
e2e/kit/assets/ios/iPhone 16 Pro/AwareScrollViewDisabledStateKeyboardClosed.png
Oops, something went wrong.
Binary file added
BIN
+182 KB
e2e/kit/assets/ios/iPhone 16 Pro/AwareScrollViewDisabledStateKeyboardOpened.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+145 KB
...kit/assets/ios/iPhone 16 Pro/AwareScrollViewKeyboardClosedWithoutBackScroll.png
Oops, something went wrong.
Binary file added
BIN
+182 KB
e2e/kit/assets/ios/iPhone 16 Pro/AwareScrollViewSecondInputFocused.png
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+194 KB
e2e/kit/assets/ios/iPhone 16 Pro/AwareScrollViewTextSelectionChanged.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+269 KB
e2e/kit/assets/ios/iPhone 16 Pro/InteractiveKeyboardAfterGestureDown.png
Oops, something went wrong.
Binary file added
BIN
+269 KB
e2e/kit/assets/ios/iPhone 16 Pro/InteractiveKeyboardAfterGestureUp.png
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+104 KB
e2e/kit/assets/ios/iPhone 16 Pro/KeyboardAnimationKeyboardIsHidden.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.