Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: react-native 0.73 #299

Merged
merged 20 commits into from
Mar 12, 2024
Merged

chore: react-native 0.73 #299

merged 20 commits into from
Mar 12, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Dec 15, 2023

📜 Description

Updated RN version to 0.73.

💡 Motivation and Context

To keep project up-to-date and assure that library can be integrated into newest RN versions.

📢 Changelog

JS

  • use @typescript-eslint/no-import-type-side-effects as alternative to importsNotUsedAsValues;
  • re-worked example app for interactive ios keyboard (since automaticallyAdjustKeyboardInsets has changed behavior since RN 0.73)

🤔 How Has This Been Tested?

Tested manually (both fabric & paper) on:

  • iPhone 15 Pro (iOS 17.2, simulator);
  • iPhone 11 (iOS 17.3, real device);
  • Pixel 7 Pro (Android 14, emulator);
  • Xiaomi Redmi note 5 Pro (Android 9, emulator).

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added the deps update Upgrade dependencies of the project label Dec 15, 2023
@kirillzyusko kirillzyusko self-assigned this Dec 15, 2023
Copy link
Contributor

github-actions bot commented Dec 15, 2023

📊 Package size report

Current size Target Size Difference
129578 bytes 131585 bytes -2007 bytes 📉

Copy link
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://kirillzyusko.github.io/react-native-keyboard-controller/pr-preview/pr-299/
on branch gh-pages at 2023-12-15 10:45 UTC

@kirillzyusko kirillzyusko force-pushed the chore/react-native-0.73 branch from cae6ccf to 06887f9 Compare March 12, 2024 07:57
@kirillzyusko kirillzyusko marked this pull request as ready for review March 12, 2024 10:42
@kirillzyusko kirillzyusko merged commit a9900d8 into main Mar 12, 2024
10 checks passed
@kirillzyusko kirillzyusko deleted the chore/react-native-0.73 branch March 12, 2024 11:10
kirillzyusko added a commit that referenced this pull request Mar 12, 2024
## 📜 Description

Update `Podfile.lock`.

## 💡 Motivation and Context

In
#299
I updated RN to `0.73.5`. However straight before a merge a new version
has been released, and I updated it to `0.73.6` (but I forgot to remove
Pods directory). As a result on CI we were trying to install `0.73.6`
version (without cache) when `0.73.5` was declared in `Podfile.lock`.

So this is a follow up for
#299

## 📢 Changelog

### iOS

- update `Podfile.lock`

## 🤔 How Has This Been Tested?

There is only a way to test it on CI 👀 

## 📝 Checklist

- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps update Upgrade dependencies of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant