-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: android build fail with rnx kit & treeShaking enabled #380
fix: android build fail with rnx kit & treeShaking enabled #380
Conversation
}; | ||
// Define a function to apply the monkey patch | ||
export const applyMonkeyPatch = () => { | ||
Object.assign(NativeAndroidManager.default, ModifiedNativeAndroidManager); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll check how it works today and if everything is okay, then I'll merge it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a little help from gpt!
@ashwin1014 you also need to run And there is one more eslint violation - please, fix it 🙏 |
@ashwin1014 by the way - did you check? Do these changes help to fix build issues? |
i was usually doing these changes manually from node_modules on my project. Then it used to build correctly |
Will do |
@ashwin1014 thank you for your contribution! |
📜 Description
Fixed build issues when using
@rnx-kit
.💡 Motivation and Context
When using tools like @rnx-kit from microsoft, which uses esbuild to handle bundling and also enables treeShaking, the build fails
📢 Changelog
📸 Screenshots (if appropriate):