refactor: use upstream assets.sh instead of custom openedx-assets #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/use-assets-sh
branch
from
023e8cd
to
70d5547
Compare
kdmccormick
force-pushed
the
kdmccormick/use-assets-sh
branch
from
70d5547
to
5da668e
Compare
Now that mypy 1.0.0 is out, we can get add some elegant type aliases for filter and action callback functions.
Cryptography in particular needs to be upgraded to 39.0.1: https://github.com/overhangio/tutor/security/dependabot/7 https://github.com/overhangio/tutor/security/dependabot/8 Black upgrade caused minor spacing changes.
Unfortunately, previous reqs upgrade was not compatible with python 3.7 because isort dropped support for that "almost EOL" version: PyCQA/isort#2064
kdmccormick
force-pushed
the
kdmccormick/use-assets-sh
branch
2 times, most recently
from
39f7d2b
to
0ab841f
Compare
When ENABLE_WEB_PROXY=false, Caddy was overriding the X-Forwarded-* headers. This is a change that was introduced in 2.5.0. We upgrade to 2.6.3 to use the new global "trusted_proxies" directive. https://github.com/caddyserver/caddy/releases/tag/v2.6.3 https://github.com/caddyserver/caddy/releases/tag/v2.5.0
kdmccormick
force-pushed
the
kdmccormick/use-assets-sh
branch
from
ac7b55f
to
243bab7
Compare
kdmccormick
force-pushed
the
kdmccormick/use-assets-sh
branch
from
243bab7
to
c580d47
Compare
kdmccormick
force-pushed
the
kdmccormick/use-assets-sh
branch
from
c580d47
to
5311f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #28