This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
run: Bring back k8s tests for dragonball #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's do it as GHA is not really stable at the moment Fixes: kata-containers#5704 Signed-off-by: Fabiano Fidêncio <[email protected]>
|
/test |
bergwolf
approved these changes
Jul 7, 2023
studychao
approved these changes
Jul 7, 2023
|
/retest-ubuntu-metrics |
|
/test-ubuntu-metrics |
|
/test-dragonball |
2 similar comments
|
/test-dragonball |
|
/test-dragonball |
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jul 7, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: #0000 Depends-on: github.com/kata-containers/tests#5705
fidencio
force-pushed
the
topic/bring-back-k8s-tests-for-dragonball
branch
from
3b73ebb
to
a51583d
Compare
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jul 7, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jul 7, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jul 8, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705
|
/test |
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jul 8, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jul 8, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/bring-back-k8s-tests-for-dragonball
branch
from
481fe55
to
1b61b71
Compare
|
/test |
fidencio
force-pushed
the
topic/bring-back-k8s-tests-for-dragonball
branch
from
1b61b71
to
14ee963
Compare
|
/test |
YushuoEdge
added a commit
to openanolis/kata-containers
that referenced
this pull request
Jul 10, 2023
We've noticed this caused regressions with the k8s-oom tests, and then decided to take a step back and do this in the same way it was done before 67972ec. And by doing this we can re-enable the k8s-oom.bats tests, which is done as part of this PR. Fixes: kata-containers#7271 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Yushuo <[email protected]>
YushuoEdge
added a commit
to openanolis/kata-containers
that referenced
this pull request
Jul 10, 2023
We've noticed this caused regressions with the k8s-oom tests, and then decided to take a step back and do this in the same way it was done before 67972ec. And by doing this we can re-enable the k8s-oom.bats tests, which is done as part of this PR. Fixes: kata-containers#7271 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Yushuo <[email protected]>
YushuoEdge
added a commit
to openanolis/kata-containers
that referenced
this pull request
Jul 10, 2023
We've noticed this caused regressions with the k8s-oom tests, and then decided to take a step back and do this in the same way it was done before 67972ec. Moreover, this step back is also more reasonable in terms of the controlling logic. And by doing this we can re-enable the k8s-oom.bats tests, which is done as part of this PR. Fixes: kata-containers#7271 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Yushuo <[email protected]>
|
/retest-s390x |
|
As all the PRs depending on this one got merged, let's re-run the dragonball test, make sure it's green, and we can finally merge it. The test was manually re-triggered. |
|
@fidencio All tests pass! Thank you so much for bringing runtime-rs test back to normal! |
studychao
pushed a commit
to openanolis/kata-containers
that referenced
this pull request
Nov 22, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Fabiano Fidêncio <[email protected]>
studychao
pushed a commit
to openanolis/kata-containers
that referenced
this pull request
Nov 22, 2023
We've noticed this caused regressions with the k8s-oom tests, and then decided to take a step back and do this in the same way it was done before 67972ec. Moreover, this step back is also more reasonable in terms of the controlling logic. And by doing this we can re-enable the k8s-oom.bats tests, which is done as part of this PR. Fixes: kata-containers#7271 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Yushuo <[email protected]>
mayamrinal
pushed a commit
to mayamrinal/kata-containers
that referenced
this pull request
Dec 13, 2023
This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Fabiano Fidêncio <[email protected]>
mayamrinal
pushed a commit
to mayamrinal/kata-containers
that referenced
this pull request
Dec 13, 2023
We've noticed this caused regressions with the k8s-oom tests, and then decided to take a step back and do this in the same way it was done before 67972ec. Moreover, this step back is also more reasonable in terms of the controlling logic. And by doing this we can re-enable the k8s-oom.bats tests, which is done as part of this PR. Fixes: kata-containers#7271 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Yushuo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's do it as GHA is not really stable at the moment
Fixes: #5704