Revert "agent: fix the issue of exec hang with a backgroud process"

This reverts commit 25d2fb0. The reason we're reverting the commit is because it to check whether it's the cause for the regression on devmapper tests. Fixes: kata-containers#7253 Depends-on: github.com/kata-containers/tests#5705 Signed-off-by: Fabiano Fidêncio <[email protected]>
mayamrinal · Dec 6, 2023 · 99d9b87 · 99d9b87
1 parent eafda10
commit 99d9b87
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/agent/rustjail/src/process.rs b/src/agent/rustjail/src/process.rs
@@ -161,7 +161,7 @@ impl Process {
 
     pub fn notify_term_close(&mut self) {
         let notify = self.term_exit_notifier.clone();
-        notify.notify_waiters();
+        notify.notify_one();
     }
 
     pub fn close_stdin(&mut self) {

diff --git a/src/agent/src/rpc.rs b/src/agent/src/rpc.rs
@@ -595,16 +595,15 @@ impl AgentService {
         let cid = req.container_id;
         let eid = req.exec_id;
 
-        let term_exit_notifier;
+        let mut term_exit_notifier = Arc::new(tokio::sync::Notify::new());
         let reader = {
             let s = self.sandbox.clone();
             let mut sandbox = s.lock().await;
 
             let p = sandbox.find_container_process(cid.as_str(), eid.as_str())?;
 
-            term_exit_notifier = p.term_exit_notifier.clone();
-
             if p.term_master.is_some() {
+                term_exit_notifier = p.term_exit_notifier.clone();
                 p.get_reader(StreamType::TermMaster)
             } else if stdout {
                 if p.parent_stdout.is_some() {