Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang version to v1.22.9 #5820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Thist PR bump Golang to the latest v1.22 release.

Which issue(s) this PR fixes:
Part of #5796

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada now built with Golang v1.22.9.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 15, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rainbowmango. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2024
@RainbowMango
Copy link
Member Author

Found a weird failing test:

=== Failed
=== FAIL: pkg/search/proxy/store TestMultiClusterCache_Get/get_pod_with_large_resource_version (0.00s)
    multi_cluster_cache_test.go:423: Unexpected error: <nil>
    --- FAIL: TestMultiClusterCache_Get/get_pod_with_large_resource_version (0.00s)

=== FAIL: pkg/search/proxy/store TestMultiClusterCache_Get (0.00s)
I1115 02:35:53.177859   28832 multi_cluster_cache.go:100] Add cache for cluster cluster1
I1115 02:35:53.177907   28832 cluster_cache.go:86] Add cache for cluster1 /v1, Resource=pods
I1115 02:35:53.178040   28832 cluster_cache.go:86] Add cache for cluster1 /v1, Resource=nodes
I1115 02:35:53.178163   28832 multi_cluster_cache.go:100] Add cache for cluster cluster2
I1115 02:35:53.178203   28832 cluster_cache.go:86] Add cache for cluster2 /v1, Resource=pods

But I can't reproduce it after several runs on my side.
@XiShanYongYe-Chang Any thougts?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.85%. Comparing base (35b7e8f) to head (82aa1e7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5820   +/-   ##
=======================================
  Coverage   44.84%   44.85%           
=======================================
  Files         658      658           
  Lines       53917    53917           
=======================================
+ Hits        24180    24185    +5     
+ Misses      28169    28165    -4     
+ Partials     1568     1567    -1     
Flag Coverage Δ
unittests 44.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants